Season of Discovery Support + Classic Era Client 1.15.0 Support

[boktai1000]

Season of Discovery Support + Classic Era Client 1.15.0 Support

[SabreValkyrn]

Updated libraries, added Classic toc, and rebuilt AbilityData.

I don't have time to entirely test on SoD+Wrath right now, please give the latest Alpha release v2.4.0-5-gd274870-classic a try when it publishes.

[boktai1000]

So I've been playing SoD with the latest alpha you posted, but unfortunately it seems like it's not working. No Lua errors, but it's simply not reporting any out of date spells/etc for ones I know are outdated.

[SabreValkyrn]

would a configurable forgiveness window make sense? It wasn't clear or apparent to me at least until you mentioned it, but if I saw a setting it might have made sense, and maybe players could adjust as they deem necessary.

I was just thinking about that actually, the only way I'd be comfortable with it is a setting for yourself, which would be very easy to change IsHighestAlertableRank to.

I just don't want someone (whether helpfully or griefing) set the value to 0 and spam everyone with my addon name.

[boktai1000]

Absolutely! It's your addon and your name out there, so whatever makes sense and you're effectively signing yourself up for. Perhaps as feedback or my opinion on it, I'd say some sort of slider that lets us adjust the forgiveness and the default could just be what it is, and maybe a warning or something to let people know about it being spammy if it's set to same level spells/etc.

Just thinking how could you both reduce the people like me wondering if it's working but also prevent people from spamming and what type of compromise, maybe folks like myself are far and few between compared to the spammers though.

Just my thoughts and $0.02 for ya! Thanks again for the great addon and feedback.

[SabreValkyrn]

Try enabling debug with /sentinel debug, I'll test on Era/HC with an existing level 10/11 toon to see what the issue is.

But one big thing with SoD, all the runes and any non-standard spell levels would be additional complications. I also haven't checked if the core spell lists are any different or not.

[boktai1000]

I added a WA as well SpellRankWatcher to double check which is what you may see here, but here's some of what I'm seeing with Heroic Strike for example:

Rank 3 is available - https://www.wowhead.com/classic/spell=285/heroic-strike I'm at level 16 for example and this is a fresh /reload to make sure. Hope this helps!

[SabreValkyrn]

Thanks, that helps me explain what's going on.

• You're level 16
• Heroic Strike(Rank 3) is available at level 16
• "Casted 284, next rank (285) available at 16, isMax true"
  • Casted Rank 2, Rank 3 available at 16, isMax true
• Level 10-19 has a 3-4 level forgiveness window, because lower leveling is so much faster (in TBC/Wrath)

  • RankSentinel/Utilities.lua

    Lines 134 to 148 in d274870

    	function addon:IsHighestAlertableRank(nextRankLevel, casterLevel)
    	if casterLevel == 80 then
    	return nextRankLevel > casterLevel
    	elseif casterLevel < 10 then
    	return nextRankLevel > casterLevel
    	elseif casterLevel < 20 then
    	return nextRankLevel + 3 > casterLevel
    	elseif casterLevel < 70 then
    	return nextRankLevel + 2 > casterLevel
    	elseif casterLevel < 80 then
    	return nextRankLevel + 1 > casterLevel
    	end
    	return nextRankLevel > casterLevel
    	end

  • Since level cap is 25 and Classic leveling is slower than TBC/Wrath/SoM, not sure if narrower forgiveness windows would be good or just annoying

I got quite a few complaints early on about SpellRankWatcher and how obnoxious it was then people raised their pitchforks at RankSentinel.

Works for a level 13 hunter on Era

[16:04:07] Rank Sentinel: Broadcasting LEAD: Kaytla,999
[16:04:20] Rank Sentinel: Casted 1978, next rank (13549) available at 10, isMax false
[16:04:20] Rank Sentinel:  Serpent Sting (Rank 1) was used, there's a newer rank at level 10.
[16:04:20] Rank Sentinel: Broadcasting NOTIFY: Player-5107-017BDE78-13-1978

My level 10 on HC is a Rogue so can't downrank to validate and don't have a toon on SoD at all yet.

[boktai1000]

Ah! I understand - would a configurable forgiveness window make sense? It wasn't clear or apparent to me at least until you mentioned it, but if I saw a setting it might have made sense, and maybe players could adjust as they deem necessary.

Maybe that would allow the best of both worlds? Not sure, just throwing it out there! :) Thanks so much for the detailed analysis and reply!

[SabreValkyrn]

v2.5.0 on its way out with updated libraries and 1.5.0.

I'll see about that instant feedback toggle at some point relatively shortly.