Comments (10)
It's not your fault. There was an incompatibility issue with swipeable tabs which are a new component in F7.
I fixed the bug in the latest version of welcomescreen.js: https://github.com/valnub/Framework7-Plugin-Welcomescreen/blob/master/welcomescreen.js
Update to this new version and it should work.
from framework7-plugin-welcomescreen.
Ah, ok. I found the problem. Has nothing to do with swipeable tabs.
That "end tutorial" button is not part of this lib. Thus, you have to attach an event listener for it on your own.
See in the example code, there you will find something like this:
$$(document).on('click', '.tutorial-close-btn', function () {
welcomescreen.close();
});
I would not recommend to add .close-welcomescreen
class to that button as it is intended for the "skip" button only.
from framework7-plugin-welcomescreen.
Can you provide a runnable example of your code with jsfiddle? Your code looks ok so far, so there must be a mistake somewhere else.
from framework7-plugin-welcomescreen.
Here the (incomplete) code but the error is still there:
http://www.stileinverso.it/demo/welcomescreen/www.zip
I found why the error occours: I use swipeable tabs in main view!
If you run the code and click "Skip" or "End tutorial" -> Error!
Now try to change this in the HTML code (line 38):
<div class="tabs-swipeable-wrap">
With this:
<div class="">
And the error goes away, your plugin works but that class is required like the docs says here:
http://framework7.io/docs/tabs.html#swipeable-tabs
I don't understand :-/
from framework7-plugin-welcomescreen.
Hi, valnub!
With your update the problem is been solved.
However I had to change this code:
{
id: 'slide3',
picture: '<div class="tutorialicon">☆</div>',
text: 'Thanks for reading! Enjoy this app.<br><br><a id="tutorial-close-btn" href="#">End Tutorial</a>'
}
With this:
{
id: 'slide3',
picture: '<div class="tutorialicon">☆</div>',
text: 'Thanks for reading! Enjoy this app.<br><br><a href="#" class="link color-white close-welcomescreen">End Tutorial</a>'
}
I.E.: <a id="tutorial-close-btn" href="#">End Tutorial</a>
-> <a href="#" class="link color-white close-welcomescreen">End Tutorial</a>
I hope I've done in a correct way, otherwise please tell me where I'm wrong.
I hope it could be useful for other people!
Thank again!
from framework7-plugin-welcomescreen.
Hi, why did you have the HTML markup? I only updated the welcomescreen.js file and that worked for me
from framework7-plugin-welcomescreen.
Sorry, I forgot to tell you the reason why I modified that HTML code.
The "Skip" button works, but the "End tutorial" not with the original code!
Can you test it?
from framework7-plugin-welcomescreen.
Hm, that's very weird because in the example from this repo it works https://github.com/valnub/Framework7-Plugin-Welcomescreen/tree/master/example
from framework7-plugin-welcomescreen.
Yes, it works if you don't use swipeable tabs from main view!
from framework7-plugin-welcomescreen.
Ok, problem solved!
Thanks!!
from framework7-plugin-welcomescreen.
Related Issues (20)
- Welcomescreen Not Close on Android HOT 3
- graceful exit *feature request* HOT 1
- F7/Phonegap/Vue: "Dom7 is undefined" HOT 2
- Error in V3 for Vue HOT 2
- Different Background Color for each slide HOT 1
- Dot navigation / # of slides HOT 1
- Does not work or load at all HOT 11
- Using framework7 components in the slides HOT 1
- Doesn't work with Framework7 v4.3.0 HOT 3
- not setting f7params.welcomescreen shows an empty screen HOT 2
- closing animation - how can this be achieved? HOT 4
- Using iOS fullscreen, leaves a gap HOT 1
- UglifyJS has trouble HOT 2
- welcomescreen.js: Line 185 : Uncaught TypeError: swiper.destroy is not a function HOT 8
- Pagination: Bullets colour - unable to change HOT 3
- navigation arrows HOT 1
- Not Working on Framework7 V6 Vue
- Not workin on Framework7 V6 Vue HOT 1
- This plugin is not working with latest version of framework7. Neither in core nor in react. HOT 13
- Not working with [email protected] & VueJS & SCSS HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework7-plugin-welcomescreen.