Giter Site home page Giter Site logo

Comments (3)

valpackett avatar valpackett commented on June 3, 2024

hah wow you're actually using this client :)

We'll need some actual "set header" functionality in that case… e.g. currently the form/json functions replace all headers with Content-Type. (Wait, maybe a User-Agent is already present on defaultRequest and this is what removes it?)

from magicbane.

akhra avatar akhra commented on June 3, 2024

Ah, that's very likely -- I'm sure I remember there being a default set when I used http-conduit a few projects back. I've got a function in my local codebase that's roughly union newHeaders existingHeaders, I'll see about making it generic and sending a PR tomorrow.

from magicbane.

akhra avatar akhra commented on June 3, 2024

Unfortunately there is no User-Agent in defaultRequest. But #14 makes it far easier to add one downstream, and also prevents postForm/postJson clobbering headers added before their use.

I didn't directly address this for now, to avoid messing with style/structure too much -- e.g. I'm not sure if having unqualified export lists is a priority -- and also I have no idea what the agent string should be.

from magicbane.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.