Missing copyright notices from apitrace

[jrfonseca]

Missing copyright notices from apitrace

[richgel999]

The lack of copyright was an oversight which we'll correct. Sorry about that. We appreciate all that you and the community have invested into apitrace, btw. We use and rely upon it ourselves.

-Rich

Sent from my iPhone

On May 10, 2014, at 4:58 PM, José Fonseca [email protected] wrote:

I'm disappointed to see that vogl cherry-picked several pieces of source code from apitrace without including a single copyright notice.

Please re-read the apitrace license, in particular the paragraph that says:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
and comply with the licensing terms.

Also, the comment in

vogl/src/voglcore/vogl_platform.cpp

Line 128 in bd9ebcf

// Derived from apitrace, but this code appears to have been copied around and tweaked from multiple sources:

is untrue. The apitrace signal handler code was not copied. These URLs are references for similar signal handlers used to give an idea of what is or not normal/acceptable behavior. I would appreciate if you would remove this baseless comment.

—
Reply to this email directly or view it on GitHub.

[jrfonseca]

Thanks. I'm happy for vogl to use whatever apitrace bits deemed useful. But I mind this sort of thing.

I have yet to give vogl a test drive, but I plan to.

[mikesart]

Hi José. I just went through and cleaned all this up - please let me know if there is anything in there you've got any comments or suggestions on. Thank you very much - definitely appreciate all the work you folks have put into this area.
-Mike

[jrfonseca]

Thanks Mike. Looks good.