Comments (6)
Can I take this issue?
from temporai.
Please feel free to do so, but I would recommend waiting until PR #64 is merged (in the next day or two), as that has a couple of changes to docstrings
from temporai.
Thank you for advice:) I will immediately start the task after PR.
from temporai.
Please feel free to get started. Many thanks for taking this on!
Please read the following before contributing:
- Contributing guide: https://temporai.readthedocs.io/en/latest/contributing.html
- Developer's guide: https://temporai.readthedocs.io/en/latest/dev_guide.html
I would also recommend joining the slack - please join the #temporai
channel so you can ask us any questions and get answers quickly.
Below is some info specifically for this task.
Overview:
- We use Google-style docstrings.
- Sphinx cross-referencing of python objects can be useful for this task.
I recommend using pydocstyle
as follows:
- After you install the library with the
dev
extra in editable mode (pip install -e .[dev]
), dopip install pydocstyle
. - You can then just run the
pydocstyle
command in the repo root to see any documentation issues that need to be resolved. pydocstyle
error codes can be found here.- Please remove these lines: https://github.com/vanderschaarlab/temporai/blob/main/pyproject.toml#L55-L62. They currently suppress the pydocstyle
D10*
errors about missing documentation. Since we want to get to 100% docstring coverage, this will help you identify where docstrings are missing. - You can then just address the
pydocstyle
issues reported.
To build documentation locally and check there are no warnings or errors introduced by your changes, run:
tox -e docs
See here for what this command does.
I recommend running this occasionally as you add docstrings to check everything works.
If you would like to use conda
environments for tox, you can install pip install tox-conda
first.
At the end of this, we can add a pydocstyle
check to the pre-commit config, so that documentation is enforced going forward.
from temporai.
Yep, go ahead
from temporai.
Thank you for whole bunch of advices:) I will start immediately. I only need 1-2 days for analyse all informations. Obviously I will join the slack. Can I create my own fork?
Best regards,
from temporai.
Related Issues (20)
- [Enhancement] Introduce plugin types
- Embrace mypy strict typing
- Fix test failure due to `cmaes` import failure with optuna 3.4+
- [Bug] Catboost is required, but fails to build (macOS 13.5) HOT 2
- [Enhancement] Integration with `omop-learn`
- [Epic] Interpretability Methods
- [Feature Request] Treatment effect estimation with temporal treatment, but single timepoint outcome HOT 1
- [Enhancement] Implement TE-CDE
- [Enhancement] Implement CausalTransformer
- [Enhancement] Migrate linting to `ruff`
- [Documentation] Train/Test split in tutorials HOT 1
- Make metrics plugin-able
- [Documentation] List Torch version requirement (Not working with pytorch==1.12) HOT 1
- [Bug] CRNTreatmentsRegressor can not be trained on GPU
- Conditional probability HOT 1
- [Bug] <static data imputation issue> HOT 4
- treatments.temporal.regression.crn_regressor wth categorical variables HOT 1
- [Bug] benchmarts not work for TimeToEvent dataset with ValidationError
- [Feature Request] <Save dataset for later usage>
- [Feature Request] <Clustering Algorithm>
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from temporai.