Giter Site home page Giter Site logo

Comments (6)

Rhobar9 avatar Rhobar9 commented on June 8, 2024 1

Can I take this issue?

from temporai.

DrShushen avatar DrShushen commented on June 8, 2024 1

Please feel free to do so, but I would recommend waiting until PR #64 is merged (in the next day or two), as that has a couple of changes to docstrings

from temporai.

Rhobar9 avatar Rhobar9 commented on June 8, 2024 1

Thank you for advice:) I will immediately start the task after PR.

from temporai.

DrShushen avatar DrShushen commented on June 8, 2024 1

@Rhobar9

Please feel free to get started. Many thanks for taking this on!

Please read the following before contributing:

I would also recommend joining the slack - please join the #temporai channel so you can ask us any questions and get answers quickly.

Below is some info specifically for this task.


Overview:

I recommend using pydocstyle as follows:

  • After you install the library with the dev extra in editable mode (pip install -e .[dev]), do pip install pydocstyle.
  • You can then just run the pydocstyle command in the repo root to see any documentation issues that need to be resolved.
  • pydocstyle error codes can be found here.
  • Please remove these lines: https://github.com/vanderschaarlab/temporai/blob/main/pyproject.toml#L55-L62. They currently suppress the pydocstyle D10* errors about missing documentation. Since we want to get to 100% docstring coverage, this will help you identify where docstrings are missing.
  • You can then just address the pydocstyle issues reported.

To build documentation locally and check there are no warnings or errors introduced by your changes, run:

tox -e docs

See here for what this command does.
I recommend running this occasionally as you add docstrings to check everything works.
If you would like to use conda environments for tox, you can install pip install tox-conda first.

At the end of this, we can add a pydocstyle check to the pre-commit config, so that documentation is enforced going forward.

from temporai.

DrShushen avatar DrShushen commented on June 8, 2024 1

Yep, go ahead

from temporai.

Rhobar9 avatar Rhobar9 commented on June 8, 2024

Thank you for whole bunch of advices:) I will start immediately. I only need 1-2 days for analyse all informations. Obviously I will join the slack. Can I create my own fork?
Best regards,

from temporai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.