Deepin compatibility

[varietywalls]

Deepin compatibility

[es20490446e]

The naming of the files is like this:
5a8a902147cb8a1e22f7e5220f4153c6.jpg

[es20490446e]

If I:

1. Set the Variety fetched folder as the same as the Deepin wallpapers folder.
2. Fetch a wallpaper.

It appears two entries of the same wallpaper, one named "[name]_1.jpg" and the other "[name]_2.jpg". It doesn't happen when using a different fetched folder, double checked.

If I disable fetching, no entry is created. So Deepin doesn't fetch itself.

[es20490446e]

I came to the same conclusion myself, that the design flaw is in Deepin itself.

I have reported it here. Thanks for your help.

[es20490446e]

They agreed to remove the wallpaper folder, so this means that Variety will work on Deepin too!

[es20490446e]

Also reported to Launchpad.

[peterlevi]

I'm extremely wary of Variety automatically deleting stuff, especially in bulk. This has caused problems before (e.g. the download quota implementation). Also Variety does not "own" the /home/user/Pictures/Wallpapers folder in any way, so it sounds wrong for it to delete it.

What is the exact behavior in Deepin - if I switch 3 times between the files "abc.jpg" and "xyz.jpg" as wallpapers, what files will end up in /home/user/Pictures/Wallpapers - just "abc.jpg" and "xyz.jpg" or 6 differently named files?

[gleitoncampos]

The process is:

1. Variety download the img from a source to the folder /home/user/.config/variety/Downloaded/(Name_of_the_source)/ OR pick a img from one of the folders used as sources in the variety configuration;
2. When variety apply a wallpaper, whatever it is (Downloaded,favorite, another folder), it will copy the img with a random name to the folder /home/user/Pictures/Wallpapper. If the folder Wallpaper don't exist, variety will create it.

If, for example, i will not download anything from variety, i will use a folder that i store my imgs. So, i put this folder in the list of sources of the variety. When it choose any img, variety will duplicate it to the Wallpaper folder with a random name. So, in some time, i will end with a folder "Cool Imgs", my original folder, and a folder "Wallpaper", created by variety, with the same content but with different names.

If the folder Wallpaper already exists and i'm using it to store the original imgs (my case), when it choose any img, it will duplicate the img in the same folder. But the duplicate just happen if the img with the random name don't exist. If I delete the img duplicated by the variety, when it choose that img again in the source, the duplicate will occur again, If I delete the original file, with the correct name, the duplicate don't occur.

I will be glad to post my variety configs, but for some reason, in the Deepin 15.5, when i click on the variety icon in taskbar, nothing happen. Tried uninstall, purge, reinstall but nothing. Seems that the "purge" commands isn't deleting config files stored in /usr/share/variety. If i delete it manualy, and reinstall, the preferences show for the first time, but the icon in the taskbar don't work...

PS: I'm the guy that posted the bug um launchpad.

[es20490446e]

If I:

1. Delete the Deepin wallpapers folder.
2. Create a blank file with its same name.

Variety is no longer able change wallpaper. Nevertheless deleting the Deepin folder after selecting a wallpaper doesn't prevent Variety from working.

[es20490446e]

So it seems that Variety is unable to control what happens in the Deepin Wallpapers folder in any way.

I think that the least surprising behaviour would be this. The first time that Variety is launched to copy the content of the Deepin Wallpapers folder into the Variety Fetched Wallpapers folder, then each time Variety changes wallpaper to remove the Deepin Wallpapers folder.

What do you think? Can I implement the fix like this?

[es20490446e]

Better than that. Before changing wallpaper, Variety could check the content of the Wallpapers folder.

• If the content is the current wallpaper only, Variety removes the folder.
• If the content is more than the current wallpaper, Variety moves it into the Fetched folder. Then shows a notification about it.

[jlu5]

These replies are getting long winded... What is the actual problem we want to solve? Is Deepin making extra copies of wallpapers whenever you apply them? Variety alone shouldn't be doing anything like that at a cursory glance of set_wallpaper.

[es20490446e]

Deepin makes a copy of every wallpaper you set inside "~/Pictures/Wallpapers", with an unlimited quota.

The folder gets huge pretty fast.

[jlu5]

I'm marking this as wontfix per https://bugs.launchpad.net/variety/+bug/1732293/comments/8

Rereading the context and Peter's response I think that this weird behaviour should really be fixed in Deepin instead of worked around in Variety. Your best bet is probably to use a specific folder for storing download images and automatically remove ~/Pictures/Wallpapers with a cronjob or something.

[jlu5]

Great to hear, and thanks for being so thorough & detailed the whole way! :)