Comments (6)
I believe I broke this one, assigning to myself.
from libvmod-example.
Hi Ingvar,
I have started a new VMOD this week and took this as an occasion to clean the build system, including this issue, #26 and #27.
The main changes are:
- the use of autotools's test driver
- we get the same green PASS and red FAIL as Varnish
- I also have unit tests in this module (out of scope)
- simpler dependencies with generated sources
- explicit dependencies between
$(srcdir) and $ (builddir) [1] - declaration of all the files created by the vmodtool
- the man page is generated in the
src/
directory
- explicit dependencies between
- a cleanup of the RPM spec file
- a cleanup of
.gitignore
I believe I also managed to remove all target/source names duplication in the makefiles, without overdoing it. I barely touched configure.ac
, only to search the VTC test suite there. I haven't touched the debian directory.
So it works on my machine, but...
- could you please try to build this module on different platforms, including el5?
- @lkarsten could you also please review it?
If it's OK for the both of you, I'll submit a pull request with similar changes.
Happy New Year,
Dridi
[1] $(builddir) no longer appears in the makefiles
from libvmod-example.
Hello, Dridi. Nice work!
I have not done any functionality testing, only builds and make check.
Builds fine on fedora. Builds fine on el5, el6, and el7 as well.
The build needs varnish-4.1 to build, but configure does not stop nor warn on varnish-4.0 (default on epel7). It should.
Do you want me to put this up at https://copr.fedoraproject.org/coprs/ingvar/varnish41/ ?
Ingvar
----- On Jan 2, 2016, at 12:43 PM, Dridi Boukelmoune [email protected] wrote:
Hi Ingvar,
I have started a new VMOD this week and took this as an occasion to clean the build system, including this issue, #26 and #27 .
The main changes are:
* the use of autotools's test driver
* we get the same green PASS and red FAIL as Varnish
* I also have unit tests in this module (out of scope)
* simpler dependencies with generated sources
* explicit dependencies between $(srcdir) and $(builddir) [1]
* declaration of all the files created by the vmodtool
* the man page is generated in the src/ directory
* a cleanup of the RPM spec file
* a cleanup of .gitignore
I believe I also managed to remove all target/source names duplication in the makefiles, without overdoing it. I barely touched configure.ac , only to search the VTC test suite there. I haven't touched the debian directory.
So it works on my machine, but...
* could you please try to build this module on different platforms, including el5?
* @lkarsten could you also please review it?
If it's OK for the both of you, I'll submit a pull request with similar changes.
Happy New Year,
Dridi
[1] $(builddir) no longer appears in the makefiles
—
Reply to this email directly or view it on GitHub .
from libvmod-example.
Hey Ingvar,
I have not done any functionality testing, only builds and make check.
It should work up to make distcheck
, and package builds from a make dist
tarball. However there is currently no functionality.
The build needs varnish-4.1 to build, but configure does not stop nor warn on varnish-4.0 (default on epel7). It should.
I'm not sure branches of this repo check for the Varnish version in configure, I can fix that too.
As for myself I had only tested the build on a mock cache (fc22) I had on my machine, I was offline and luckily I had done Varnish 4.1 mock builds previously.
The VMOD hasn't been started yet. I'm barely starting with HPACK, so I think it is way too early to consider packaging it in your COPR repo. I'll keep that in mind though :)
Dridi
from libvmod-example.
Going back to the original subject, I'm not sure it's a good idea to include man pages in the distribution. They depend on the vmodtool
used at build-time, so I'm not sure it's a good idea to save them at dist-time.
from libvmod-example.
Closing for the reason stated in my previous comment.
from libvmod-example.
Related Issues (14)
- Disclaim of copyright for vmod template? HOT 5
- relax license HOT 8
- need to use the same varnishd and varnishtest as building against HOT 1
- autoconf on el6 fails HOT 1
- configure fails on systems with older pkg-config HOT 1
- vcc target and parallell make fails on first run. HOT 1
- Make always build all sources. HOT 3
- or
- Build fail with Varnish 4.0.0 HOT 5
- Version Incompatible between Varnish and vmod_example HOT 2
- Install instructions need to be updated for Varnish 4.0 HOT 37
- make distcheck fails
- Add FPM packaging files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libvmod-example.