THREE.WebGLRenderer : useLegacyLights depreciated

[NikooDev]

THREE.WebGLRenderer : useLegacyLights depreciated

[vasturiano]

@NikooDev it is already updated, since v2.29.0.
30bbe17

It's forcing it to false (modern behavior) in case it encounters an older version of three (before 155), so that it has a consistent behavior. Imo, that warning shouldn't be launched by three when that property is set to false (the current default), only when it's set to true.

[LC43]

hi thanks for the latest updates!
Since the property is actually deprecated, it's triggering the notice because globe.gl is setting it.
Either not set it, or if you want to support older versions of three, wrap that line in a check for three version < 155.

[vasturiano]

@LC43 we could that, but how does one check the running version of the ThreeJS renderer?

[vasturiano]

@LC43 I've made the fix that you suggested. So, the warning should be no more in future versions of globe.gl.

[LC43]

thanks @vasturiano ! i confirm the warning is gone, well done!