Giter Site home page Giter Site logo

Comments (6)

Talia-12 avatar Talia-12 commented on July 18, 2024

I'm having the same issue on 1.20.1, after investigating for a bit I think that the issue is with the following from BookRecipeSerializer:

  public @NotNull U fromNetwork(@NotNull ResourceLocation id, @NotNull FriendlyByteBuf buf) {
      T recipe = this.compose().fromNetwork(id, buf);
      return (Recipe)this.converter().apply(recipe, (Object)null);
  }

passing null into the converter is breaking assumptions later on, it should be (I'm pretty sure) the ResourceLocation outputBook.

from patchouli.

michaelortnerit avatar michaelortnerit commented on July 18, 2024

Same Error. Have to remove the mod and then it was working to join the server. It is the 1.20.1 version too.

from patchouli.

CDAGaming avatar CDAGaming commented on July 18, 2024

Can report the same issue here too, with the 1.20.1 port that was pushed to CurseForge today. Had to advise my users to remove the mod in the meantime.

from patchouli.

williewillus avatar williewillus commented on July 18, 2024

@Talia-12 That null was explicitly placed there by 9b3ac17

@Hubry do you remember why this was done?

from patchouli.

williewillus avatar williewillus commented on July 18, 2024

Oh actually, I see the bug. The code shifted around in 1.19 I believe, will fix.

from patchouli.

williewillus avatar williewillus commented on July 18, 2024

a82e9f4
will release a 1.19 backport shortly

from patchouli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.