Giter Site home page Giter Site logo

Comments (6)

ewanm89 avatar ewanm89 commented on July 17, 2024

Also to note, the spell has 2 smite and an ignite trick on the closest entity, Could first trick have killed the mob before second trick fired causing a null pointer in the entity list?

from psi.

yrsegal avatar yrsegal commented on July 17, 2024

Isn't smite damage calculation after the spell executes?
On Fri, Feb 12, 2016 at 3:09 PM Ewan Marshall [email protected]
wrote:

Also to note, the spell has 2 smite and an ignite trick on the closest
entity, Could first trick have killed the mob before second trick fired
causing a null pointer in the entity list?


Reply to this email directly or view it on GitHub
#17 (comment).

from psi.

ewanm89 avatar ewanm89 commented on July 17, 2024

Yrsegal, from what I can tell from reading the code, the null pointer exception was during an iteration of the list to calculate the closest to the point. I don't know of any other possible reason the list might suddenly have a null entry in it? Maybe vazkii can work it out? Also the death may be from fire from a previous invocation. After all I was spamming it at the mobs chasing me at the time..,

from psi.

yrsegal avatar yrsegal commented on July 17, 2024

Shouldn't any exception in checking just be a spellCompilationException,
though?
On Fri, Feb 12, 2016 at 6:12 PM Ewan Marshall [email protected]
wrote:

Yrsegal, from what I can tell from reading the code, the null pointer
exception was during an iteration of the list to calculate the closest to
the point. I don't know of any other possible reason the list might
suddenly have a null entry in it? Maybe vazkii can work it out? Also the
death may be from fire from a previous invocation. After all I was spamming
it at the mobs chasing me at the time..,


Reply to this email directly or view it on GitHub
#17 (comment).

from psi.

yrsegal avatar yrsegal commented on July 17, 2024

Ok, here are the two possibilities. A null entity, which Vazkii should check for, and a null position which should throw spellCompilationException.

from psi.

Vazkii avatar Vazkii commented on July 17, 2024

3cc99ea

from psi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.