Giter Site home page Giter Site logo

Comments (5)

guitargeek avatar guitargeek commented on June 7, 2024 1

No, not entirely. It solves the current remaining warning in the nighlies, yes, but we have still "hotfixed" away several warnings in ROOT Math:
https://github.com/guitargeek/root/blob/master/math/mathcore/inc/Math/Types.h#L11

Once Vc is in a state where we get no warnings in the ROOT nightlies without the pragmas, then I would consider this issue as solved.

Thanks for the work you have done already, @bernhardmgruber and @dpiparo 👍

from vc.

bernhardmgruber avatar bernhardmgruber commented on June 7, 2024

Hi! Vc is no longer developed. If you can provide a PR, I can help you get it in. In the long term I would try to migrate to std::simd. There is a fallback implementation available if you have to support compilers without std::simd: https://github.com/mattkretz/vir-simd

from vc.

dpiparo avatar dpiparo commented on June 7, 2024

for the time being: #356 . If you are happy with the pr, your test suite and nightlies pass, could you tag a new version so that it can be included e.g. in ROOT? Thanks a lot in advance!!

from vc.

bernhardmgruber avatar bernhardmgruber commented on June 7, 2024

I merged the PR on Vc.

from vc.

bernhardmgruber avatar bernhardmgruber commented on June 7, 2024

@guitargeek, does PR #356 entirely solve this issue?

from vc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.