test failure on precise due to no zsh

[vcstools]

test failure on precise due to no zsh

[tkruse]

well, ... get zsh?
If rosinstall supports zsh tab completion, and we want to make sure we don't break it, I see little alternatives as to install zsh for the tests.

[tfoote]

It would be a lot cleaner to instead of asserting zsh is present to test if zsh is present and skip the zsh test if not present. Otherwise this is an undeclared dependency and adding zsh is a little backwards. Likewise bash should probably be detected and conditionally skipped.

[tkruse]

-1
"clean" and "backward" seem rather subjective, and I happen to see this in the opposite way. bash and zsh are not runtime dependencies, because users are free to use rosinstall without either. They are however test dependencies (like mock or nose) because anyone touching any generated *.sh file should get a failure as soon as possible if breaking bash or zsh. skipping tests because test dependencies are not met is not a valid approach (we would not think of it for mock or nose neither).
Skipping tests should not be an option for the lazy, it is a last-resort method when a test is near-impossible to be made to run. "sudo apt-get install zsh" is not near impossible.

I bet if we had skipping in place, you would not even have so much as blinked at the test results, and never thought of installing zsh. That in itself is a benefit of this test.

[dirk-thomas]

Closing since the repository is about to be archived: see #126.