Small bug

[mconsidine]

Small bug

[Vdesnoux]

Thanks… i added the crop just lately so may be too fast. This is to avoid wrong top and bottom y1 and y2 pos due to large black areas with high tilt levels. Maybe some issues added or unforeseen… Will have a deeper look within few days V

…

Le 14 nov. 2021 à 16:25, mconsidine ***@***.***> a écrit :  FYI, For a strongly tilted image I wanted to process, I needed to force the "crop" variable to 0. That allowed the processing to continue, but it then halted at line 912 of Inti_recon.py The call to detect_edges needs to have crop=crop added to it there, as it is in other calls. Downsized examples of the raw and clahe image are attached Hope this helps. Any advice on using "crop" in these circumstances would be appreciated! Matt — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[mconsidine]

Thanks. It appears that large tilt levels are a "feature" of the classic spectrohelioscope we have at Stellafane. The tracking mirror sits off to the side of the steering mirror, both of which feed the sunlight to the (fixed) horizontal telescope. That appears to induce a tilt when the steering mirror is used to drive the image across the slit. Untested yet is speeding up the tracking mirror to try to accomplish the same thing.
Matt

[Vdesnoux]

I found that in this case, in the detect-edge function the value of y2 shall not be changed, and thus the line y2=y2+crop shall be deleted or commented.
Only for this case, more robust algorithm shall be considered for large tilt in the 2 possible directions. To be continued...