v2.0.0: warnings when compiling with clang

[vdr-projects]

v2.0.0: warnings when compiling with clang

[madmartin]

Another warning:

In file included from displaybase.c:17:
displaybase.c: In member function ‘void cDisplay::DrawText(int, int, const char*, int, enumTeletextColor)’:
logging.h:42:44: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 9 has type ‘size_t’ {aka ‘unsigned int’} [-Wformat=]
 #define dsyslog_ot(format, arg...) dsyslog("osdteletext: DEBUG %s/%s: " format, __FILE__, __FUNCTION__, ## arg)
logging.h:60:65: note: in expansion of macro ‘dsyslog_ot’
 #define DEBUG_OT_DTXT   if (m_debugmask & DEBUG_MASK_OT_DTXT )  dsyslog_ot
                                                                 ^~~~~~~~~~
displaybase.c:678:5: note: in expansion of macro ‘DEBUG_OT_DTXT’
     DEBUG_OT_DTXT("called with x=%d y=%d len=%d text='%s' strlen(text)=%ld", x, y, len, text, strlen(text));
     ^~~~~~~~~~~~~

This patch fixes it:

--- vdr-plugin-osdteletext-2.0.0.orig/displaybase.c
+++ vdr-plugin-osdteletext-2.0.0/displaybase.c
@@ -675,7 +675,7 @@ void cDisplay::DrawTextExtended(const in
 
 void cDisplay::DrawText(int x, int y, const char *text, int len, const enumTeletextColor cText) {
     // Copy text to teletext page
-    DEBUG_OT_DTXT("called with x=%d y=%d len=%d text='%s' strlen(text)=%ld", x, y, len, text, strlen(text));
+    DEBUG_OT_DTXT("called with x=%d y=%d len=%d text='%s' strlen(text)=%d", x, y, len, text, strlen(text));
 
     cTeletextChar c;
     c.SetFGColor(cText); // default ttcWhite

[pbiering]

Preview: https://github.com/pbiering/vdr-plugin-osdteletext/tree/2.0.1-regression, please test

[madmartin]

Hi,
well done, plugin works and no more warnings from both gcc and clang.
From my side the bunch of clang settings in Makefile is not necessary.
Closing.

[pbiering]

From my side the bunch of clang settings in Makefile is not necessary.

I need them here for testing compilation with clang on a "default" gcc system