ast.Field#Definition is nil unexpectedly in Fragment walking

[vektah]

ast.Field#Definition is nil unexpectedly in Fragment walking

[vektah]

Yeah I had a go here, still a long way off and I'm going to leave it for now and concentrate on integration gqlparser with gqlgen (in a branch).

One thing I noticed is those tests refer to Type, which doesn't exist in the schema so it will always be nil. I added it temporarily to get things passing

I've been making most of the visitors call at the end, so the walker never exposes unbound Definitions (if it can find them)

eg https://github.com/vektah/gqlparser/blob/master/validator/walk.go#L113 happens after all the childen have been walked, so any defs should be defined

As far as pointers I kinda agree, I've been moving away from them in a few places but I don't think its required here

You can still do

// use i here instead of `i, sel` otherwise you take a pointer to a copy.
for i := range field.SelectionSet {
	w.walkSelection(def, &field.SelectionSet[i])
}

func (w *Walker) walkSelection(parentDef *ast.Definition, it *ast.Selection) {
    // ...
}

to get a pointer to the element in the slice, the slice elements never change.

[vvakame]

ah, sorry. I wrote type SelectionSet []*Selection but Selection is interface...
https://play.golang.org/p/Ud0TMZHTFbM
We can't use *ast.Selection I think...

One thing I noticed is those tests refer to Type

I found same things. f1, f2 and f3 is not exists in schemas... spec

[vvakame]

https://play.golang.org/p/6_4HFmMhdlU 🤔

[vektah]

I'm not sure what your trying to do, https://gitter.im/gqlgen/parser?