Giter Site home page Giter Site logo

Comments (4)

BenJackGill avatar BenJackGill commented on May 4, 2024

Any update on this?

I added an async modifier to the onRetry callback but my await functions are not awaited.

To follow on from your example:

    return retry(
      async (_, attempt) => {
        await downloadFileFromInternet();
      },
      {
        onRetry: async (err) => {
         // It happens that downloaded file has an error
         // I want to delete the downloaded corrupted file
         await fs.unlink(pathToCorruptedFile); // This does not wait
        },
        retries: 3
      }
    );

from async-retry.

tvld avatar tvld commented on May 4, 2024

Actually, are you sure? In my case await in onRetry() seems to work just fine

from async-retry.

BenJackGill avatar BenJackGill commented on May 4, 2024

When I was facing this problem I was fairly sure that was the problem. I now use p-retry instead.

from async-retry.

JiriKovar avatar JiriKovar commented on May 4, 2024

I'm sure that the onRetry() is not awaited... It seems we will need to drop the usage of this package because for this reason as there is no workaround and its easier then rewriting everythin we need to use in onRetry to a synchronous implementation.

from async-retry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.