Giter Site home page Giter Site logo

`aws-sdk` errors about ncc HOT 3 CLOSED

vercel avatar vercel commented on July 16, 2024
`aws-sdk` errors

from ncc.

Comments (3)

NateRedding avatar NateRedding commented on July 16, 2024 3

Was this issue resolved? I am getting the same error with the aws-sdk using rollup.js to bundle up my lambda code. Ncc seems like a slightly better fit though, and I'd be willing to switch if this problem was solved.

from ncc.

guybedford avatar guybedford commented on July 16, 2024

Had a deeper look at this one, and this seems to be a very interesting execution order bug in the commonjs plugin.

Basically, somehow because of the way that the proxy module works, it's not quite executing modules in the right tree order.

This seems like an important bug to fix.

from ncc.

guybedford avatar guybedford commented on July 16, 2024

The issue at play here is also ultimately cycles, but it is exacerbated by the following:

index.js

require('./x')();
require('./y');

x.js

module.exports = function () {
  require('./y');
}

Because we statically turn x.js into by CJS -> ESM conversion:

import './y';
export default function () {
  y;
}

This means that y is now imported and executed earlier in the graph than it would have been.

This makes no difference here, but introduce cycles and it causes real execution ordering differences.

from ncc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.