Giter Site home page Giter Site logo

Comments (2)

Maxim-Mazurok avatar Maxim-Mazurok commented on July 19, 2024 2

I can confirm that original issue was fixed, however now tests that have any if or switch in them are getting flagged.. I use if and switch in mocked implementation, so it probably shouldn't be flagged...
Example:

vi.spyOn(
  currencyConverter,
  "baseCurrencyOnDateInTargetCurrency",
).mockImplementation((currency: Currency) => {
  // eslint-disable-next-line vitest/no-conditional-tests
  if (currency.equals(new Currency("AUD"))) {
    return 1;
    // eslint-disable-next-line vitest/no-conditional-tests
  } else if (currency.equals(new Currency("USD"))) {
    return 1.5;
  }
  throw new Error("not implemented");
});

In jest there are two rules: no-conditional-expect and no-conditional-in-test to differentiate, might be a good idea.

from eslint-plugin-vitest.

Maxim-Mazurok avatar Maxim-Mazurok commented on July 19, 2024

Same, all of my tests got flagged, the only ones that didn't are it.each() tests

from eslint-plugin-vitest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.