Comments (2)
I can confirm that original issue was fixed, however now tests that have any if or switch in them are getting flagged.. I use if and switch in mocked implementation, so it probably shouldn't be flagged...
Example:
vi.spyOn(
currencyConverter,
"baseCurrencyOnDateInTargetCurrency",
).mockImplementation((currency: Currency) => {
// eslint-disable-next-line vitest/no-conditional-tests
if (currency.equals(new Currency("AUD"))) {
return 1;
// eslint-disable-next-line vitest/no-conditional-tests
} else if (currency.equals(new Currency("USD"))) {
return 1.5;
}
throw new Error("not implemented");
});
In jest there are two rules: no-conditional-expect
and no-conditional-in-test
to differentiate, might be a good idea.
from eslint-plugin-vitest.
Same, all of my tests got flagged, the only ones that didn't are it.each()
tests
from eslint-plugin-vitest.
Related Issues (20)
- vitest/expect-expect shouldn't require assertions for bench HOT 1
- Feature request: `consistent-test-file-path` HOT 2
- Feature request: formatting rules HOT 1
- Invalid flat config HOT 2
- `bench` throw error `Prefer using it instead of test within describe`
- `expect-expect` fails even if `expectTypeOf` is present HOT 7
- Add require `describe`, `it` and `vi` import HOT 1
- Extend the `no-identical-title` rule to support `suite` test block pattern HOT 4
- Consider rule for naming mocks created with `vi.fn()` HOT 1
- Results of weekly scheduled smoke test HOT 1
- Throwing with ESLint 9 and flat config HOT 1
- [BUG] Converting circular structure to JSON HOT 5
- Please provide non-flat config HOT 6
- Declaration file missing plugin configs
- Results of weekly scheduled smoke test HOT 8
- TypeError: Converting circular structure to JSON when extend the recommended HOT 2
- Feature request: `prefer-vi-mocked` HOT 1
- tsc: Fix issues related to types HOT 1
- Readme docs is outdates
- Publish v0.6.0 to NPM HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-vitest.