Rules

[veritem]

Rules

[sheremet-va]

I am suggesting these:

• expect expect inside a test
• enforce either test or it, but not both
• prefer either toBeCalled or toHaveBeenCalled (and so on)
• prefer await expect().resolves.toBe/await expect().rejects.toBe instead of expect(await ...).toBe
• enforce either chai style or jest style assertions

[sapphi-red]

Maybe it is possible to add license and copy some rules from https://github.com/jest-community/eslint-plugin-jest.
I think most of the rules can be copied and modified a bit.

[narthur]

Would also be nice to have a rule like this:

https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/unbound-method.md

I'm running into this issue because the default ESLint version of this rule flags cases like this:

expect(my_func).toBeCalled()

[veritem]

Yes PRs are welcome

[veritem]

Thank you!

[togami2864]

@veritem Can I work on lower case title ?

[dammy001]

@veritem can I help out with some rules?

[veritem]

nice idea @sapphi-red , would you mind sending a PR?

[sapphi-red]

Sorry, but I can't do it right now because my hands are full.

[JoshuaKGoldberg]

Behold, below: table showing which rules exist in which plugin! Table key:

• ✔️: exists in eslint-plugin-jest
• ❌: does not exist in eslint-plugin-jest
• ✅: exists in eslint-plugin-vitest

Two questions:

• For the ❌ rules, did I just miss a renamed rule? Or should those be filed as issues on eslint-plugin-jest?
• no-jasmine-globals looks to be pretty Jest-specific; are there other rules that don't need to be implimented in eslint-plugin-vitest?

	eslint-plugin-jest	eslint-plugin-vitest?
consistent-test-it	✔️	✅
expect-expect	✔️	✅
max-expects	✔️	✅
max-nested-describe	✔️	✅
no-alias-methods	✔️	✅
no-commented-out-tests	✔️	✅
no-conditional-expect	✔️	✅
no-conditional-in-test	✔️	✅
no-conditional-tests	❌	✅
no-deprecated-functions	✔️
no-disabled-tests	✔️	✅
no-done-callback	✔️	✅
no-duplicate-hooks	✔️	✅
no-export	✔️
no-focused-tests	✔️	✅
no-hooks	✔️	✅
no-identical-title	✔️	✅
no-if	✔️ (deprecated)	❌
no-interpolation-in-snapshots	✔️	✅
no-jasmine-globals	✔️	(not applicable)
no-large-snapshots	✔️	✅
no-mocks-import	✔️	✅
no-restricted-jest-methods	✔️	✅
no-restricted-matchers	✔️	✅
no-skipped-tests	❌	✅
no-standalone-expect	✔️	✅
no-test-prefixes	✔️	✅
no-test-return-statement	✔️	✅
prefer-called-with	✔️	✅
prefer-comparison-matcher	✔️
prefer-each	✔️
prefer-equality-matcher	✔️
prefer-expect-assertions	✔️
prefer-expect-resolves	✔️
prefer-hooks-in-order	✔️
prefer-hooks-on-top	✔️
prefer-lowercase-title	✔️	✅
prefer-mock-promise-shorthand	✔️
prefer-snapshot-hint	✔️
prefer-spy-on	✔️
prefer-strict-equal	✔️
prefer-to-be	✔️	✅
prefer-to-contain	✔️
prefer-to-have-length	✔️
prefer-todo	✔️
require-hook	✔️
require-to-throw-message	✔️
require-top-level-describe	✔️
valid-describe-callback	✔️
valid-expect-in-promise	✔️
valid-expect	✔️	✅
valid-title	✔️	✅
no-restricted-vi-methods	❌	✅

[veritem]

thank you @JoshuaKGoldberg !!! will use this for future development