Giter Site home page Giter Site logo

Comments (12)

veritem avatar veritem commented on August 20, 2024

Would you mind sending a repro?

Here there is different use cases for this I can add yours if it's not covered

from eslint-plugin-vitest.

qeleb avatar qeleb commented on August 20, 2024

I haven’t got time to send over a repro today & my issue is in a private repo.

this test is passing? i’ve had this same bug since 0.0.20.

I’ve also found that expect-expect errors on run (something about length of property undefined), and no-identical-title seems not to do anything

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

@qeleb, those were fixed a few weeks ago. update the package to the latest version

from eslint-plugin-vitest.

qeleb avatar qeleb commented on August 20, 2024

i’m using latest

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

@qeleb I would love it if you could share a sample code for something that's not working. This way, I can look into it and fix it as soon as possible.

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

Hi, let me know if you're still experiencing the same issue. If that's the case, feel free to re-open this

from eslint-plugin-vitest.

qeleb avatar qeleb commented on August 20, 2024

Hi! Yes, please reopen this issue.

Unfortunately, all of these problems still exist in 0.0.30.
I've just done a test this morning to verify.

It has improved massively since I got this eslint plugin weeks ago, but some are still not working, so my eslint config looks like this:

env: { 'vitest-globals/env': true },
rules: {
  'vitest/consistent-test-it': ['error', { fn: 'it' }],
  //'vitest/expect-expect': 'error', // broken
  //'vitest/lower-case-title': 'warn', //autofix broken
  'vitest/max-nested-describe': ['error', { max: 3 }],
  'vitest/no-conditional-tests': 'error',
  'vitest/no-focused-tests': 'warn',
  //'vitest/no-identical-title': 'error', // broken
  'vitest/no-skipped-tests': 'warn',
},

vitest/expect-expect & vitest/no-identical-title don't work at all, but lower-case-title is really close to working.
It correctly identifies tests with uppercase letters, but autofix litters the titles with extra spaces.

Example:
[GET] /404: missing route => [ g e t] /404: missing route

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

Please use the latest version, I'm not sure why this is still occurring for you here is my example. It works perfectly https://github.com/veritem/eslint-plugin-vitest/tree/main/fixtures

from eslint-plugin-vitest.

qeleb avatar qeleb commented on August 20, 2024

@veritem
try making it say “[TEST]: This is a Test”
i think some characters like the square bracket are breaking it.

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

fyi, It capitalizes the first character. If it can't be capitalized let's say it's a number or special character it leave it as it is.

from eslint-plugin-vitest.

qeleb avatar qeleb commented on August 20, 2024

then why is the current version adding a bunch of spaces on autofix? something is not adding up…

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

I haven't seen this may be an example would help me fix it asp. I have tried this [TEST]: This is a Test it doesn't do anything to the text.

from eslint-plugin-vitest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.