Giter Site home page Giter Site logo

Comments (6)

veritem avatar veritem commented on August 20, 2024 2

Should be released in latest version and thank you so much for reporting this

from eslint-plugin-vitest.

p4trykJ avatar p4trykJ commented on August 20, 2024 2

It works like a charm! Thanks

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024 1

hey, would you mind sharing an example code where this is not running correctly so that I can make sure to include it in tests?

from eslint-plugin-vitest.

p4trykJ avatar p4trykJ commented on August 20, 2024

Hi 👋 I think the same problem has just occurred for me. Here's an example:

import { it } from 'vitest';
describe('Button with increment', () => {
    it('should show name props', () => {
        console.log('test with missing expect');
    });
});

After I remove the import the rule is working properly.

from eslint-plugin-vitest.

stevezhu avatar stevezhu commented on August 20, 2024

Hi 👋 I think the same problem has just occurred for me. Here's an example:

import { it } from 'vitest';
describe('Button with increment', () => {
    it('should show name props', () => {
        console.log('test with missing expect');
    });
});

After I remove the import the rule is working properly.

@veritem This is a good example. As @p4trykJ said, if the import statement is removed, the test works properly, but if the import statement exists, it doesn't.

I put more details in the pr I opened for this issue. Feel free to pull this fix into a new branch along with tests or otherwise use it however you want: #42

from eslint-plugin-vitest.

stevezhu avatar stevezhu commented on August 20, 2024

Awesome, thanks for the fast review!

from eslint-plugin-vitest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.