require destructured from `expect` from test context, when using snapshots in concurrent tests

[dimaMachina]

require destructured from `expect` from test context, when using snapshots in concurrent tests

[veritem]

This should be a different rule that handles this kind of behavior. Open for PRs

[connorjs]

Should there be an option to enforce this only for concurrent, but allow it to be forced for everything?

Note: I’m new to Vitest. From my reading of the docs, I though the destructured form was only “needed” in the concurrent case.

[veritem]

Yeah, destructuring is needed for concurrent tests. Wouldn't this be great if it was a different rule?

[connorjs]

Yes, I think it should be a new rule.

• I think it would be included in the recommended set to require it for concurrent cases.
• Assuming you can destructure in the non-concurrent case (I'm new to Vitest), I think we should have an option similar to always that enforces it everywhere. (This would make it easier to switch to concurrent.)
• Ideally, this would be auto-fixable.

I have never written an ESLint rule, so I do not know how “involved” this would be to submit a PR, but it could be good learning.

[veritem]

this was resolved check docs