Giter Site home page Giter Site logo

Comments (9)

veritem avatar veritem commented on August 20, 2024 1

Will for sure add it soon; thanks for pointing it out.

from eslint-plugin-vitest.

orept avatar orept commented on August 20, 2024 1

Worked after adding to config:

...
plugins: [..., 'vitest'],
env: {
    ...
    'vitest/env': true,
  },

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

hello @goosewobbler would you mind giving latest version a quick test and see it it works like you'd like?

I added globals and thanks for firing this issue

please use "extends": ["plugin:vitest/all"] or "extends": ["plugin:vitest/all"] to make sure everything works perfectly

from eslint-plugin-vitest.

goosewobbler avatar goosewobbler commented on August 20, 2024

I don't see the globals being exported - but I realised that I personally don't need them anyway as I'm importing them from vitest directly, e.g.

import { vi, describe, beforeEach, afterEach, it, expect } from 'vitest';

In order to use the globals in Vitest like Jest does, you need to explicitly enable them in config:
https://vitest.dev/config/#globals

So exporting the same globals that eslint-plugin-vitest-globals does will still be useful for anyone using the above config setting. Thanks for the recommended ruleset though, that's very helpful.

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

I thought I added globals as you've request them. Would you mind firing a PR? I don't understand what you mean, but I would like to help you.

from eslint-plugin-vitest.

goosewobbler avatar goosewobbler commented on August 20, 2024

This is what eslint-plugin-vitest-globals exports: https://github.com/saqqdy/eslint-plugin-vitest-globals/blob/master/index.js#L11

from eslint-plugin-vitest.

camsteffen avatar camsteffen commented on August 20, 2024

That should be in the readme.

from eslint-plugin-vitest.

veritem avatar veritem commented on August 20, 2024

@camsteffen can you share your whole config? I would like to have a look.

from eslint-plugin-vitest.

camsteffen avatar camsteffen commented on August 20, 2024

Sure, this should be a complete example.

module.exports = {
  plugins: ["vue", "vitest"],
  env: {
    browser: true,
    es2021: true,
  },
  extends: [
    "eslint:recommended",
  ],
  overrides: [
    { files: ".eslintrc.cjs", env: { node: true } },
    { files: "vite.config.js", env: { node: true } },
    {
      files: "**/*.test.js",
      extends: "plugin:vitest/recommended",
      env: {
        "vitest/env": true,
      },
    },
  ],
};

from eslint-plugin-vitest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.