Make the 'instance_id' UA configuration parameter public

[versatica]

Make the 'instance_id' UA configuration parameter public

[jmillan]

Yeah

[saghul]

Can we call that "instance_id" ? The implementation uses a URN, but as a concept it expresses an instance identifier: https://tools.ietf.org/html/rfc5626#section-4.1

Also, should jsSIP verify that the given instance id is a valid urn?

[jmillan]

This parameter already exists and its name is instance_id ;-). It is a non public configuration parameter right now.

Of course, it will verify the urn syntax.

[saghul]

José Luis Millán wrote:

This parameter already exists and its name is |instance_id| ;-). It is
a non public configuration parameter right now.

Of course, it will verify the urn syntax.

—
Reply to this email directly or view it on GitHub
#49 (comment).

Great! I hope you don't planto change it to "urn" ;-)

[jmillan]

Not at all. It is The instance_id ;-)

[ibc]

instance_id is a proper name, but +sip.instance Contact header param requires a URN so validation of the field is required (otherwise parsing errors could occur somewhere.

Could you please write an example of such a parameter usage?

[jmillan]

It is already implemented internally. I will make the parameter public so it will be validated against the proper syntax as any configuration parameter does.

The following can be seen from a running UA instance.

coolPhone.configuration.instance_id -> 1758eab0-806c-40bb-a88d-710b99503965

The Contact header in a Register request is generated as it needs to:

Contact: <sip:[email protected];transport=ws>;reg-id=1;+sip.instance="<urn:uuid:1758eab0-806c-40bb-a88d-710b99503965>";expires=600

[ibc]

Please, properly document in the API that the value must not contain "urn:uuid:" nor "<" and ">".

Theorically the user provided value should be an entire URN (i.e.: "urn:uuid:xxxx-xxxx-xxxx-xxxx") but we can require just the "xxxx-xxxx-xxxx" fragment if properly documented.

[jmillan]

Yes. First I will take it to the public API, and the document.

[ibc]

Updates to this issue please? It is marked for 0.3.x but AFAIK it is not. If so better leaving it for 0.4.x.

[jmillan]

No updates at all. Well set to 0.4.x

[jmillan]

New UA configuration parameter: 'instance_id':

764dc90

[walidsynclio]

HI,
I tried to set instance_id but no luck.
coolPhone.instance_id says undefined.
Even if I add instance_id to configuration it does not show up in the sip request packet. it has some other vlue in sip request packet.
Thanks

[jmillan]

Hi @walidsynclio,

The instance_id is a new configuratin parameter in the 'devel' branch. It is not in the current 'master' branch. Are you using the 'devel'?