Giter Site home page Giter Site logo

Comments (5)

mnaser avatar mnaser commented on September 4, 2024 1

closed by @stefan-chivu -- awesome work!

from magnum-cluster-api.

lukasmrtvy avatar lukasmrtvy commented on September 4, 2024

ping, its doable now :)

from magnum-cluster-api.

stefan-chivu avatar stefan-chivu commented on September 4, 2024

Hi folks, I was wondering why the work for supporting Flatcar Linux has been halted.

I would be interested to contribute and I'd like to know if the work done so far has any reason to be stopped or if it just happened to get to the back of the list of priorities.

from magnum-cluster-api.

mnaser avatar mnaser commented on September 4, 2024

@stefan-chivu at the time, there was a couple of pending items and we got focused on adding support for other things. the way I think we can do this:

  1. create a new driver called k8s_cluster_api_flatcar
  2. create a driver class linked to the above called FlatcarDriver
  3. Use "flatcar" in the "os" field there
  4. In this section you will see how we create the ClusterClass and then use it later, I suggest that we create a new variable for the ClusterClass called operatingSystem and then passing that down when creating the Cluster (like a variable being set here https://github.com/vexxhost/magnum-cluster-api/blob/main/magnum_cluster_api/resources.py#L1660-L1665 called operatingSystem) and defined https://github.com/vexxhost/magnum-cluster-api/blob/main/magnum_cluster_api/resources.py#L758-L773 and json patches like https://github.com/vexxhost/magnum-cluster-api/blob/main/magnum_cluster_api/resources.py#L1231-L1238)

With this, you'll be able to detect if a system is using flatcar, change operatingSystem based on that, and then adjust the different templates in the cluster class

Also, probably would be good to https://github.com/vexxhost/magnum-cluster-api/blob/main/magnum_cluster_api/cmd/image_builder.py to include support for flatcar as well.

@stefan-chivu does that give a fair bit of context? i'm more than happy to provide some resources too in terms of an env/etc+review+chat to discuss it through (fyi, we are in #atmosphere on the kubernetes slack, we're trying to lock down #magnum-cluster-api too)

from magnum-cluster-api.

mnaser avatar mnaser commented on September 4, 2024

@stefan-chivu seems to have followed up!

https://kubernetes.slack.com/archives/C05Q8TDTK6Z/p1695293755953929

Hoping to see the PR soon :D

from magnum-cluster-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.