Question about sample_with_time (oversampling)

[victimsnino]

Question about sample_with_time (oversampling)

[victimsnino]

@mincequi,
To be honest, you can achieve requested behavior with something like this:

#include <rpp/rpp.hpp>
#include <iostream>

auto sample_with_time_oversampling(rpp::schedulers::duration period, const auto& scheduler)
{
    return [=](const auto& observable)
    {
        return rpp::source::interval(period, scheduler)
                .with_latest_from([](const auto&, const auto& v) { return v; }, observable);
    };
}


int main()
{
    auto start = rpp::schedulers::clock_type::now();
    rpp::source::interval(std::chrono::milliseconds{1000}, rpp::schedulers::trampoline{})
            .op(sample_with_time_oversampling(std::chrono::milliseconds{500},
                                              rpp::schedulers::trampoline{}))
    .take(10)
            .subscribe([&](size_t v)
            {
                std::cout << "get value " << v << " at " << std::chrono::duration_cast<std::chrono::milliseconds>(rpp::schedulers::clock_type::now() - start) << std::endl;
            });
    return 0;
}

Output:

get value 0 at 1008ms
get value 0 at 1506ms
get value 1 at 2010ms
get value 1 at 2504ms
get value 2 at 3004ms
get value 2 at 3512ms
get value 3 at 4005ms
get value 3 at 4513ms
get value 4 at 5008ms
get value 4 at 5502ms

[victimsnino]

Ohh, i see.

I have both, but not time-based versions. I've created issues for them
#312
#313

[victimsnino]

Hi @mincequi,

I'm not sure if it is expected behavior... "demo" for this operator from ReactiveX proves that no any additional emission in case of oversampling:

Same about RxJava. In place of emitting value it "clears" old value, so it is not possible that operator emits same value twice:

void emit() 
{
  T value = getAndSet(null);
  if (value != null) {
      downstream.onNext(value);
}

source

[mincequi]

Hi @victimsnino ,
yes, apparently the official behaviour is only undersampling. (like it is done in rxJava).

For that reason, i would need a time based window or time based buffer operator to tackle my desired behaviour.

So my question is, do you plan to realise buffer or window operator any time soon?
This is probably my last request for now :)

[victimsnino]

Closing due to inactivity