Add a check to avoid multiple start

[victorb]

Add a check to avoid multiple start

[dasois]

i guess then your suggestion is, that a call of start() should implicitly call stop()? Or should it throw an error if a timer is already started?

[martiro]

CHANGE1: In the start method I make a check of intervalCounterId variable:
start: function () {
// TODO Use requestAnimationFrame instead of setInterval
// https://developer.mozilla.org/en-US/docs/Web/API/window.requestAnimationFrame
this.show();
var self = this;
// RBM call setInterval only if it ha never been called
if (intervalCounterId == undefined) {
intervalCounterId = setInterval(function () {
if (isNaN(count)) {
clearInterval(intervalCounterId);
count = 0;
self.hide();
} else {

CHANGE2: in the reset function i reset the value of intervalCounterId to undefined

reset: function () {
//logger.debug("ngProgress.reset() count=" + count);
clearInterval(intervalCounterId);
intervalCounterId = undefined;
count = 0;
this.updateCount(count);
return 0;
},

CHANGE3: in the nested timeout I simply call the reset method

complete: function () {
//logger.debug("ngProgress.complete() count=" + count);
count = 100;
this.updateCount(count);
var self = this;
$timeout(function () {
self.hide();
$timeout(function () {
//count = 0;
//self.updateCount(count);
self.reset(count);
}, 500);
}, 1000);
return count;
}

Bye

[zackarychapple]

+1 I would really like if this would be resolved.