Comments (6)
ngProgress.start()
does not complete the progress-bar. Why should it?
Call ngProgress.complete()
to complete it.
from ngprogress.
Could you please reopen this issue, because I think you misread my comment. I didn't talk about the calls, I know very well how the library works. I was talking about two events that might trigger ngProgress.start(), at which point the loading bar would never fully complete.
Again, you can test this strange behavior by going to https://victorbjelkholm.github.io/ngProgress/ and clicking on Start -> Complete. Wait for it to complete then click on Start again.
CONCLUSION: The loading bar will never complete if two ngProgress.start() are made without refreshing the page.
from ngprogress.
I've just tried this out in latest Chrome (Version 37.0.2062.94 (64-bit))
and latest Firefox (Version 32.0) on Ubuntu and it seems to be working fine.
Please note that start()
and complete()
are both called before
the first time you click on "Start" and "Complete" so the bug would appear
already after your first try.
But, there is known problems with calling start()
twice without
calling complete()
after the first one, but this is not the issue, if
I understand you correctly.
I'm not sure I understand how you get this issue. Can you provide the
browser version you're using, if there is any cross-browser issue.
Edit: Re-reading the initial issue comment you made, it seems like you're indeed are clicking start twice, or doing "Start" -> "Complete" -> "Start" very fast which is known to be a bit buggy.
Sincerely,
Victor Bjelkholm
(+34) 672 15 90 89
[email protected]
On Wed, Sep 17, 2014 at 4:32 PM, Andrei [email protected] wrote:
Could you please reopen this issue, because I think you misread my
comment. I didn't talk about the calls, I know very well how the library
works. I was talking about two events that might trigger
ngProgress.start(), at which point the loading bar would never fully
complete.Again, you can test this strange behavior by going to
https://victorbjelkholm.github.io/ngProgress/ and clicking on Start ->
Complete. Wait for it to complete then click on Start again.CONCLUSION: The loading bar will never complete if two ngProgress.start()
are made without refreshing the page.—
Reply to this email directly or view it on GitHub
#56 (comment)
.
from ngprogress.
Yes to your Edit: comment. My app often completes and starts new loading bars as data arrives, which triggers this issue. Is there any fix planned?
from ngprogress.
This was closed by #48.
On the website the new release has not yet being incorporated, see #57
from ngprogress.
@dasois I have updated the gh-pages
branch but I'm afraid this is not fixed by any other issues. This issue seems to be more about calling Start
-> Complete
-> Start
very fast is buggy while #48 was more about Start
-> Start
-> Complete
and never finishing
from ngprogress.
Related Issues (20)
- website HOT 4
- Update link reference HOT 1
- Fix naming in bower.json HOT 1
- Broken API? HOT 1
- Typescript definition file HOT 1
- Versions missing from npm HOT 9
- 'main' referenced in package.json doesn't exist. HOT 4
- setParent() not work HOT 4
- Bower Install Warning HOT 2
- ngProgress injected is not the service but the factory HOT 6
- ngProgressFactory function misses it's dependencies HOT 3
- ngProgressFactory injection failed HOT 1
- Documentation issue HOT 1
- progressbar.complete() shouldn't animate unless it has been started
- first param in $timeout&progress speed HOT 1
- TypeError: 'undefined' is not an object (evaluating 'this.parent.appendChild')
- after deploy code in enviroment - ngprogress version not found HOT 1
- NPM Version Request HOT 4
- IE not reflecting DOM updates and progress bar is delayed until the page is nearly done loading HOT 1
- Request for new maintainer HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngprogress.