Giter Site home page Giter Site logo

Render error in Vue3 about vue-svg-map HOT 8 OPEN

victorcazanave avatar victorcazanave commented on May 30, 2024 2
Render error in Vue3

from vue-svg-map.

Comments (8)

VictorCazanave avatar VictorCazanave commented on May 30, 2024 1

Thank you for the link @Neon22!

My initial plan was to keep the same components (hoping they would be compatible with Vue 3) and update the wrapper to support both Vue 2 and Vue 3, but I didn't find any resources about how to do that.
Then, now I'm thinking to still keep the options API, to modify the components as less as possible (probably only the v-model), and create a new wrapper for Vue 3.

from vue-svg-map.

VictorCazanave avatar VictorCazanave commented on May 30, 2024 1

However, I identified multiple breaking changes in code, besides v-model, and also some necessary changes in the build config, etc. You might want to check out the migration build. Maybe, it is easier having a @next version of the plugin instead of maintaining compatibility for vue-2 and vue-3 in the same place.

(Very late) Thanks for your feedback!

Is there already a version that works in vue 3?

Not yet. I'll try to work on it in the following weeks.

from vue-svg-map.

VictorCazanave avatar VictorCazanave commented on May 30, 2024

Thank you for reporting this issue @mpancewicz!
This component was built for Vue 2, then I'm not surprised it doesn't work directly with Vue 3.

I'll try to make it compatible when I have free time (probably not before 2 weeks 😥).
If you know how to fix it (keeping the Vue 2 compatibility), feel free to open a PR!

from vue-svg-map.

mpancewicz avatar mpancewicz commented on May 30, 2024

Thanks,
I'd try to fix it, but as we all do I also have a problem with a free time.

from vue-svg-map.

Neon22 avatar Neon22 commented on May 30, 2024

I have a similar problem.
It doesn't look to me like both v2 and v3 can be serviced by the same code but then again maybe only the wrapper needs to have two versions as the options API still works in v3.

I don't know enough but I'll leave this here because it looks like how to change the three .vue files :

from vue-svg-map.

Neon22 avatar Neon22 commented on May 30, 2024

Also leaving this here - allows packaging for Vue2 and 3 at the same time... magical
https://github.com/vueuse/vue-demi

Ran into it here: https://vueuse.org/

from vue-svg-map.

MoeNeuron avatar MoeNeuron commented on May 30, 2024

@VictorCazanave

My initial plan was to keep the same components (hoping they would be compatible with Vue 3) and update the wrapper to support both Vue 2 and Vue 3, but I didn't find any resources about how to do that.

wrapper.js could be easily made vue-3 compatible and also typed for ts support.

However, I identified multiple breaking changes in code, besides v-model, and also some necessary changes in the build config, etc. You might want to check out the migration build. Maybe, it is easier having a @next version of the plugin instead of maintaining compatibility for vue-2 and vue-3 in the same place.

from vue-svg-map.

matzborba avatar matzborba commented on May 30, 2024

Is there already a version that works in vue 3?

from vue-svg-map.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.