VOD replay problems

[video-dev]

VOD replay problems

[mangui]

thanks for reporting @blacktrash,
video ended event is indeed indirectly triggered by hls.js :
it is fired when stream type is VoD and currentPosition is near stream duration (less than 200ms from stream duration)
see here : https://github.com/dailymotion/hls.js/blob/master/src/controller/buffer-controller.js#L533-L539

the thing is that there might be some drift between playlist duration and end of buffer position.
I checked video stats with this playlist : http://dailymotion.github.io/hls.js/demo/?src=http%3A%2Fx%2Fwww.streambox.fr%2Fplaylists%2Fx36xhzz%2Fx36xhzz.m3u8

duration : 634.583955
seekable : [0,634.583955]
played : [0,634.173929]
=> playback is stopping 400ms before duration => video Ended is not fired.

the algorithm needs to be reviewed : for example, if the playhead is not moving although video is not paused and playhead is located in last buffered VoD fragment, consider that video is ended.

[phloxic]

Yes, that's the case when video.ended is not fired.

However, the 2nd case, at http://dailymotion.github.io/hls.js/demo/?src=http%3A%2F%2Fwww.streambox.fr%2Fplaylists%2Fx212fsj%2Fx212fsj.m3u8 it is fired, but there is some buffer management problem on replay: If you seek to a previously unbuffered position the behaviour is like with progressive download: wait until everything from 0 to seek position is buffered. It's strange, because if you just seek to 0 this does not happen.

[mangui]

@blacktrash plz recheck your second scenario with hls.js/master, it should work now.
i will think about a solution for case 1.

[phloxic]

@mangui - confirming 2nd scenario - seeking to 'unbuffered' positions on replay - as fixed. Great!

[phloxic]

case 1 involves a problem with end of video detection, which manifests itself for instance with playlists where some items get stuck, especially when you don't seek previously, but just play through.
Here's a (temporary) demo: http://flowplayer.blacktrash.org/fp6/showreels.html - just run the first player, and at some point the player is stuck at the end of a video.

[mangui]

thanks @blacktrash i know how to fix this, I will try to find some time soon to trigger video ended properly, even if playback head does not come close to video duration.

[mangui]

@blacktrash scenario 2 should be fixed now, could you plz confirm that it is also working on your side ?
thanks

[phloxic]

@mangui works like a charm! 👍

[mangui]

great. closing