Comments (3)
dmlap
commented on May 29, 2024
Good point. Thanks for the report.
from videojs-contrib-ads.
RevinKey
commented on May 29, 2024
I have a PR #295 in review to address this and other instances where the loading spinner is neither displayed nor animated.
from videojs-contrib-ads.
incompl
commented on May 29, 2024
This would be a lot easier to fix in the 6.x codebase. I believe this is where you'd start. https://github.com/videojs/videojs-contrib-ads/blob/master/src/states/Preroll.js#L170 Off the cuff, maybe you'd want to add the class there (if it's not already there) rather than removing it. I haven't tested that though.
from videojs-contrib-ads.
Related Issues (20)
- Detect when Server Side Ad is playing HOT 1
- QUESTION: Ad bug in upper-left hand corner HOT 1
- Preroll not starting when following simple exemple
- Preroll wont work on livestreams
- integration with prebid
- Is this possible to play ads whenever possible?
- Library not compatible with Samsung Tizen TVs HOT 9
- WARN: Unexpected startLinearAdMode invocation (preroll)
- Does videojs-contrib-ads support Amazon IVS player? HOT 1
- Docs are wrong HOT 1
- Something wrong wrong with the repo HOT 2
- Google IMA ads not playing with DASH stream in iPhone simulation mode in Chrome browser HOT 2
- While casting to TV the player stops after the preroll HOT 2
- 'npm install' just makes errors. HOT 1
- Post roll leaves player in a stuck state HOT 3
- Is there any way to clear or deregister the videojs-contrib-ads plugin for removing event binding and such as? HOT 1
- How to avoid preroll checks every time when change video source src？ HOT 1
- Need Help to create queue system for loading ads
- Why mid-roll ad not working when changing playback speed from 1 to 2?
- Preroll doesn't start after resume video
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from videojs-contrib-ads.