Comments (5)
Feels like this would be a pretty straightforward thing to submit an unsolicited PR on. Easier for maintainers to approve or critique than to sit down and do the work, nah?
I think documentation should ideally come from people who know the project. I could mention that Phlex is supported and not much else, but I'm sure a knowledgeable person would think of other points worth mentioning.
I generally don't do PRs that are not desired, as the work may be wasted. In the case of documentation it might only be a few minutes, so your point would stand if I really knew enough to be a source of information.
If you know enough to have anything useful to say, you could do it.
from lookbook.
I've added a very brief note on compatibility here - hopefully that is enough to get interested people to click through to the main docs site.
I'll go ahead and close this now, thanks for your input everyone.
from lookbook.
@brandondrew so sorry for the slow reply. PR's are always appreciated but it's no problem for me to add a note in the README about Phlex support. To be honest I thought I had already mentioned it in there but apparently not!
It's definitely a good idea to mention it so I'll add a short note with a link out to the documentation for more info.
Thanks for bringing it to my attention :)
from lookbook.
Feels like this would be a pretty straightforward thing to submit an unsolicited PR on. Easier for maintainers to approve or critique than to sit down and do the work, nah?
from lookbook.
Yes, please submit a PR if you can dedicate some time to it, it will help move this forward! Thanks
from lookbook.
Related Issues (20)
- Add the ability to hide a nested within a group. HOT 3
- Cannot choose display options in an embedded preview HOT 4
- Support better errors / web console instead of rescuing errors in Lookbook HOT 2
- undefined method `strftime' for nil:NilClass with nil datetime HOT 1
- Hidden scenarios within groups are not accessible via their URL
- Swap the order of Previews and Pages sections HOT 4
- Ability to search within pages section HOT 3
- X-Frame-Options always set to deny HOT 8
- Can't draw templates that require instance variables HOT 5
- Lookbook overrides ViewComponent `show_previews` config depending on load order HOT 3
- ActionView::Template::Error occurs when trying to render a template file with a partial HOT 5
- FEA: Support for Mailer Previews HOT 1
- Support configurable frame ancestors for embeds HOT 2
- Previews not rendering nested components HOT 2
- Better integration with Phlex HOT 1
- Version requirement for listen gem is not specified, and wrong version error is suppressed HOT 1
- Syntax error reporting in Lookbook HOT 2
- Sharing View Component Previews Across Multiple Projects Without Duplicating Files
- Enlarge search field clear button
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lookbook.