Giter Site home page Giter Site logo

Comments (5)

brandondrew avatar brandondrew commented on May 25, 2024 2

Feels like this would be a pretty straightforward thing to submit an unsolicited PR on. Easier for maintainers to approve or critique than to sit down and do the work, nah?

I think documentation should ideally come from people who know the project. I could mention that Phlex is supported and not much else, but I'm sure a knowledgeable person would think of other points worth mentioning.

I generally don't do PRs that are not desired, as the work may be wasted. In the case of documentation it might only be a few minutes, so your point would stand if I really knew enough to be a source of information.

If you know enough to have anything useful to say, you could do it.

from lookbook.

allmarkedup avatar allmarkedup commented on May 25, 2024 2

I've added a very brief note on compatibility here - hopefully that is enough to get interested people to click through to the main docs site.

I'll go ahead and close this now, thanks for your input everyone.

from lookbook.

allmarkedup avatar allmarkedup commented on May 25, 2024 1

@brandondrew so sorry for the slow reply. PR's are always appreciated but it's no problem for me to add a note in the README about Phlex support. To be honest I thought I had already mentioned it in there but apparently not!

It's definitely a good idea to mention it so I'll add a short note with a link out to the documentation for more info.

Thanks for bringing it to my attention :)

from lookbook.

dhnaranjo avatar dhnaranjo commented on May 25, 2024

Feels like this would be a pretty straightforward thing to submit an unsolicited PR on. Easier for maintainers to approve or critique than to sit down and do the work, nah?

from lookbook.

Spone avatar Spone commented on May 25, 2024

Yes, please submit a PR if you can dedicate some time to it, it will help move this forward! Thanks

from lookbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.