Giter Site home page Giter Site logo

Comments (12)

Inferis avatar Inferis commented on June 15, 2024

Ah yes, good catch.

from viewdeck.

argentini avatar argentini commented on June 15, 2024

Has this issue been resolved? If not, I'm wondering if a workaround exists, like manually setting the panning mode during a specific center view event like viewWillAppear (which does not fire, but I'm using it as an example anyway).

Would the fix simply be to automatically snap the center view shut if it's dragged within "X" number of points of the left edge during a right-to-left pan? I'm an experienced programmer but new to iOS development, so please forgive my ignorance. Just trying to help!

from viewdeck.

lhasiuk avatar lhasiuk commented on June 15, 2024

I downloaded the latest version to give it a try, but it doesn't run at all in our project, so I had to go back to the version from a few days before. I haven't had a chance to try to track down the issues to see what's going wrong with it.

from viewdeck.

bonebox avatar bonebox commented on June 15, 2024

I'm seeing a similar issue, except that the center view doesn't get enabled when I drag it all the way back to the left then release. I was able to fix it by adding a "x == 0" OR condition to the following line in the "panned:" method.

if ((self.leftController.view.hidden && !leftWasHidden) || (self.rightController.view.hidden && !rightWasHidden) || x == 0) { [self centerViewVisible]; }

from viewdeck.

argentini avatar argentini commented on June 15, 2024

That fixed the issue for me as well. This issue may be able to be closed at this point once it's regression tested. Isn't open source awesome? Thanks bonebox!

from viewdeck.

bonebox avatar bonebox commented on June 15, 2024

Well, after posting that I realized it's not a complete fix because the appropriate delegate methods don't get called. The problem seems to be that it still thinks the left/right views are open. I inserted some hacky code to get it working, but hopefully Tom or someone can do a proper fix.

from viewdeck.

ashchan avatar ashchan commented on June 15, 2024

Still seeing this problem. If you drag the center view very slowly to left until it stops at the left screen bound (try to drag it off the left edge), then the center view is still not interactive.

from viewdeck.

marcosanson avatar marcosanson commented on June 15, 2024

Yes, I confirm that the issue is still present.
If you drag the center view to the original position, then the center view is not interactive.

from viewdeck.

marcosanson avatar marcosanson commented on June 15, 2024

anyone have found a solution?

from viewdeck.

Inferis avatar Inferis commented on June 15, 2024

Check out the latest update to master (version 1.4.2). Let me know how it works out for you guys.

from viewdeck.

marcosanson avatar marcosanson commented on June 15, 2024

Hi Tom,
just tested and it works fine!

You only have these two lines of code in IIViewDeckController.m that generate warnings because are not used:

BOOL rightWasHidden = self.rightController.view.hidden;
BOOL leftWasHidden = self.leftController.view.hidden;

Thanks for the patch

from viewdeck.

argentini avatar argentini commented on June 15, 2024

Agreed. This release seems to have fixed the issue. I, too, commented out the offending (unreferenced) variables. Thanks for the fix!

from viewdeck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.