Giter Site home page Giter Site logo

Comments (6)

BereGabor avatar BereGabor commented on May 31, 2024

I implement this issue

from repostat.

vifactor avatar vifactor commented on May 31, 2024

Great! May I ask you then when you do that, please, separate the command option parsing and analysis launching into different files, i.e. gitstats split into e.g. repostat.py (main file with argparse, check dependencies, usage, etc.) and git_repo_analysis.py (which would contain for now html report creator and data collector).

from repostat.

BereGabor avatar BereGabor commented on May 31, 2024

Ok. I could move data collector and HTMLGenerator classes in separate files too.

from repostat.

BereGabor avatar BereGabor commented on May 31, 2024

I would like to submit the whole solution in more PR. The first should be the refact to avoid difficult merges. ( as i currently do :) )

from repostat.

BereGabor avatar BereGabor commented on May 31, 2024

Subtask under this issues as i see. I'll submit PR per subtask if it's OK:

  • Refact code: done
  • PEP8 style, pycharm re format, and warning fixes: PR Submited
  • migrate command: todo

We could do this?

from repostat.

vifactor avatar vifactor commented on May 31, 2024

I am absolutely fine for all three points in your plan

from repostat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.