Regression: spell checking no longer works in perlPOD in DATA section

[grr]

Regression: spell checking no longer works in perlPOD in DATA section

[dkearns]

@petdance I have some significant changes to the Pod syntax file that also address spell checking but I haven't looked at them for a few months so I might not get to creating a PR until the end of next week.

Did you want to me make an intermediate one that fixes this and maybe addresses a couple of other simple spell-check issues?

[petdance]

Can you tell what specifically in the commit broke it?

@dkearns any ideas?

[dkearns]

I think the following will restore the old behaviour?

diff --git a/syntax/pod.vim b/syntax/pod.vim
index e6f8335..fec8915 100644
--- a/syntax/pod.vim
+++ b/syntax/pod.vim
@@ -43,7 +43,7 @@ syn match podForKeywd "\S\+" contained contains=@NoSpell
 " An indented line, to be displayed verbatim
 syn region podVerbatim start="^\s\+\S.*$" end="^\ze\s*$" end="^\ze=cut\>" contains=@NoSpell
 
-syn region podOrdinary start="^\S.*$" end="^\ze\s*$" end="^\ze=cut\>" contains=podFormat,podSpecial,@NoSpell
+syn region podOrdinary start="^\S.*$" end="^\ze\s*$" end="^\ze=cut\>" contains=podFormat,podSpecial,@Spell
 
 " Inline textual items handled specially by POD
 syn match podSpecial   "\(\<\|&\)\I\i*\(::\I\i*\)*([^)]*)" contains=@NoSpell

[grr]

-syn region podOrdinary start="^\S.*$" end="^\ze\s*$" end="^\ze=cut\>" contains=podFormat,podSpecial,@NoSpell
+syn region podOrdinary start="^\S.*$" end="^\ze\s*$" end="^\ze=cut\>" contains=podFormat,podSpecial,@Spell

Confirmed. That fixes it.

Also, when it did work, it apparently only worked if the DATA section was marked with END and didn't work if it was marked with __DATA__

Found the issue here: #42. It looks like the change was made only because of personal preference. Most people think __DATA__ and __END__ are interchangeable and the documentation in perlpod makes no distinction here: https://perldoc.perl.org/perlpod#Embedding-Pods-in-Perl-Modules . there's also plenty of code on CPAN and the wild that has POD after a __DATA__ section (google filetype:pm "__DATA__ =head1")

[petdance]

Huh, I've never heard of anyone having POD in __DATA__, but clearly the docs say it's OK. Thanks for the research.

[petdance]

Did you want to me make an intermediate one that fixes this and maybe addresses a couple of other simple spell-check issues?

Yes, please.