Giter Site home page Giter Site logo

two bugs about image-matching-webui HOT 4 CLOSED

VEDFU avatar VEDFU commented on May 28, 2024
two bugs

from image-matching-webui.

Comments (4)

VEDFU avatar VEDFU commented on May 28, 2024

问题1:

"keypoints0": kpts0_origin.cpu().numpy(),
"keypoints1": kpts1_origin.cpu().numpy(),

这两行应该是 :
"keypoints0": kpts0.cpu().numpy(),
"keypoints1": kpts1.cpu().numpy(),
问题2: 缺少 matchers/dedode.py 文件

针对问题2:match_dense.py里面 dedode_sparse 用的是 extractors/dedode.py?

from image-matching-webui.

Vincentqyw avatar Vincentqyw commented on May 28, 2024

问题1:

"keypoints0": kpts0_origin.cpu().numpy(),
"keypoints1": kpts1_origin.cpu().numpy(),

这两行应该是 :
"keypoints0": kpts0.cpu().numpy(),
"keypoints1": kpts1.cpu().numpy(),
问题2: 缺少 matchers/dedode.py 文件

  1. Not a bug, please try again and check the visualization. The naming of keypoints may lead to ambiguity. These keypoints are used in the subsequent visualization stage, where they are plotted on the original image. Therefore, resizing the points is necessary. There are no abnormalities in this process.
  2. Key dedode_sparse is not used, so there is no matchers/dedode.py. I will delete the key.

If there are no other issues, please close the question.

from image-matching-webui.

VEDFU avatar VEDFU commented on May 28, 2024

问题1:

"keypoints0": kpts0_origin.cpu().numpy(),
"keypoints1": kpts1_origin.cpu().numpy(),

这两行应该是 :
"keypoints0": kpts0.cpu().numpy(),
"keypoints1": kpts1.cpu().numpy(),
问题2: 缺少 matchers/dedode.py 文件

  1. Not a bug, please try again and check the visualization. The naming of keypoints may lead to ambiguity. These keypoints are used in the subsequent visualization stage, where they are plotted on the original image. Therefore, resizing the points is necessary. There are no abnormalities in this process.
  2. Key dedode_sparse is not used, so there is no matchers/dedode.py. I will delete the key.

If there are no other issues, please close the question.

我是用image0/1和keypoints0/1可视化出来不一致,改之后才会一致。

我理解image0/1和keypoints0/1是对应的,都是scale之后的(带_orig后缀的是scale之前的)。按现在的写法,keypoints0和keypoints0_orig是一样的,都是keypoints0_orig(keypoints1_orig同理)

from image-matching-webui.

Vincentqyw avatar Vincentqyw commented on May 28, 2024

I appreciate your insight. To address potential ambiguity, I've enacted some modifications in the subsequent commit:

9162a57#diff-cbb7e4425d46c92eae364a7c62a58ff478af1d596e191b331396de21ab66405fL396-R420

Some Notes:

- Image Detected KeyPoints Matched KeyPoints
wo. scale image0 keypoints0 mkeypoints0
w. scale (view in UI) image0_orig keypoints0 _orig mkeypoints0_orig

from image-matching-webui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.