Comments (7)
OK that's good to know, i had a quick poke around in the source of the plugin.. and it seems like it has functions that are overrides to the standard ones..
that said, go enjoy Påskeferie...
from vipps-recurring-woocommerce.
So you know what the structure of a product looks like i've attached one of the exports
wc-product-export-8-4-2022-1649414420014.csv
you can see there is a metadata field Meta: _wcsatt_schemes
that contains data if it is a WooCommerce All product Subscription scheme.
I think I have found the code on line 411
of woo-vipps-recurring.php
and line 1453
of wc-gateway-vipps-recurring.php
from vipps-recurring-woocommerce.
There's a kind of issue with the fix for wc-gateway-vipps-recurring.php
Essentially, you're using WC_Subscriptions_Product::is_subscription()
to check if it is a subscription type product, which that SHOULD return a true, since this type of product IS a subscription product.. .but it seems that Woo hasn't added a check in that function for if its a Wcsatt type of subscription...
So the two changes should be to add a check to see IF its a simple type product that has the _wcsatt
metadata.
from vipps-recurring-woocommerce.
Hi Daniel,
I had never even heard of this plugin before, but it does seem like it isn't integrating with WooCommerce Subscriptions in the way one would expect, causing us to need additional logic to support it.
I will look into this after the Easter break, as I currently have holiday.
If you are able to fix it in the meantime feel free to submit a pull request and I'll verify that everything works once I'm back
from vipps-recurring-woocommerce.
from vipps-recurring-woocommerce.
I think refunding should still work fine as that logic is the same for WooCommerce and WooCommerce Subscriptions. I'm not completely sure about cancellation though, but seeing as All Products for WooCommerce Subscriptions is supposed to be compatible with WooCommerce Subscriptions I assume it should work with your changes.
There would definitely have to be a more permanent fix for this however, as the lines you modified are in place to prevent this payment gateway from showing up at the same time as the Vipps Checkout plugin in certain scenarios, like if manual renewals are enabled (this enables the use of single payment gateways for subscriptions) or when using Klarna Checkout.
from vipps-recurring-woocommerce.
Added in 1.14.0 (not released yet, will have to do some more testing first).
from vipps-recurring-woocommerce.
Related Issues (20)
- WooCommerce Subscriptions API v1 HOT 2
- Switching Subscriptions Does Not Update Recurring Cost HOT 4
- Ability to choose what field to source product description from
- How can we force WooCommerce Subscriptions to retry failed payments if the retry system is enabled? HOT 1
- Abort in Vipps returns incorrectly HOT 11
- Add additional sorting in our tables
- Ability to export failed or pending charges as a CSV HOT 2
- Add settings for how many charges to check at once, and what sort order to use HOT 1
- Error if "Custom description" is blank when "Description source" is set to "Custom" on a product
- Edge case: "pending-cancel" will stay as "pending-cancel" even if a charge fails
- Fatal error på noe som omhandler prevent_backwards_transition_on_completed_order :-( HOT 5
- Uncaught TypeError triggers fatal error in PHP 8.0 HOT 6
- Vipps Checkout - not showing recurring amount HOT 2
- Getting this error thrown out every minute. Any ideas on how to solve this? HOT 14
- Scheduled actions HOT 3
- Limited subscriptions show up as unlimited in Vipps app HOT 3
- Multiple Cron job errors HOT 2
- Subscription status: Pending med Vipps faste betalinger HOT 1
- Please update the links to point to the new vipps website HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vipps-recurring-woocommerce.