Giter Site home page Giter Site logo

Comments (4)

chrisgervang avatar chrisgervang commented on May 19, 2024

I prefer Option 2 for its brevity. This sounds like a great addition.

from deck.gl.

ibgreen avatar ibgreen commented on May 19, 2024

My vote:

  • I prefer to avoid nested props for a few reasons, so option 1.
  • Also we technically may not need the clear flag as omitting the color could be enough.

I am assuming that we do clear the framebuffer once before we start rendering the views, regardless of what the views state. I.e. the clear flags in the views are for controlling the composition of multiple views.

  • For reference, I updated the luma.gl RenderPass docs to reflect the current situation there, though changes to that API have been briefly discussed, so maybe we shouldn't try too hard to match it.
  • Notable is that the depthBuffer clear value can be specified, rather than just true or false. But that probably doesn't make sense for views as they all would need to follow the same depth buffer conventions.

from deck.gl.

chrisgervang avatar chrisgervang commented on May 19, 2024

I'm also fine with option 1.

from deck.gl.

Pessimistress avatar Pessimistress commented on May 19, 2024

FYI this will need to be in 9.1 because currently, we use a single render pass to draw all views. There are overlaps between LayersPassRenderOptions and the proposed view options (clearColor, clearCanvas). I suspect there will be some tricky corner cases in conflict resolution as we test the implementation.

from deck.gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.