Giter Site home page Giter Site logo

Comments (3)

abliss avatar abliss commented on June 20, 2024

I can confirm that changing the = '' in reset() back to = 0 fixes the issue, which explains why I could not reproduce in the gh-pages branch. I understand that this change was made to fix something about issue #4. But it seems to me that the best way to handle issue 4 would be to (a) defer the setting of the duration property until end() is called; (b) store the existing value, and (c) restore it to its original value after the animation finishes (rather than setting it to 0 or to '').

I don't understand exactly why an empty duration causes this issue when a duration of 0 does not, but that it probably has something to do with inheritance.

If you agree with my suggestion above, let me know and I'll be happy to prepare a pull request.

Thanks!

from move.js.

abliss avatar abliss commented on June 20, 2024

FYI, I now believe the problem here is that the 'transitionend' event bubbles up (nobody ever calls stopPropagation), so that if a child's animation ends after a parent's animation has begun, the parent's end() callbacks will be prematurely called. I have a fix locally but it requires messing with the dependencies in a rather ugly way.

from move.js.

abliss avatar abliss commented on June 20, 2024

BTW should I prepare a pull request based on master or gh-pages? It seems that gh-pages hasn't been updated in a while; example 13 in the docs doesn't seem to work in master.

from move.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.