Comments (3)
I can confirm that changing the = ''
in reset()
back to = 0
fixes the issue, which explains why I could not reproduce in the gh-pages branch. I understand that this change was made to fix something about issue #4. But it seems to me that the best way to handle issue 4 would be to (a) defer the setting of the duration property until end()
is called; (b) store the existing value, and (c) restore it to its original value after the animation finishes (rather than setting it to 0
or to ''
).
I don't understand exactly why an empty duration causes this issue when a duration of 0
does not, but that it probably has something to do with inheritance.
If you agree with my suggestion above, let me know and I'll be happy to prepare a pull request.
Thanks!
from move.js.
FYI, I now believe the problem here is that the 'transitionend' event bubbles up (nobody ever calls stopPropagation), so that if a child's animation ends after a parent's animation has begun, the parent's end() callbacks will be prematurely called. I have a fix locally but it requires messing with the dependencies in a rather ugly way.
from move.js.
BTW should I prepare a pull request based on master or gh-pages? It seems that gh-pages hasn't been updated in a while; example 13 in the docs doesn't seem to work in master.
from move.js.
Related Issues (20)
- Change site URL to http://tj.github.io/move.js
- No animation with div elements created via Javascript. HOT 5
- Move multiple dom elements? HOT 1
- animate div which have animation in it.
- apply multiple properties inside set method?
- move in not defined HOT 3
- Correct way to chain then() and end() ?
- Remove animation properties after animation is completed HOT 4
- doesnt apply on recently updated elements in angular js HOT 2
- How to loop an animation HOT 1
- remotes property in component.json produces error
- Example 1 in examples/docs.html is not working HOT 2
- Several examples are not working
- Animations in background tabs HOT 1
- Prevent exponential notation (e.g. 1.0e-19) reaching CSS
- Move#set(prop, val) when prop contain 'px' function not work
- How can I play animation for several times?
- Use jquery.easing.js Effects??
- move.js mot work on build. HOT 1
- Move.js not work on Build.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from move.js.