Giter Site home page Giter Site logo

Comments (4)

VitaliiBlagodir avatar VitaliiBlagodir commented on August 14, 2024

Hi!
Manual editin works greate on Andorid 2.3.6, 4.2.2 and 4.3.
What version of Android are you using?

For you manual editing works where these lines are uncommented?
https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/blob/master/src/android/DatePickerPlugin.java#L111
https://github.com/VitaliiBlagodir/cordova-plugin-datepicker/blob/master/src/android/DatePickerPlugin.java#L148

from cordova-plugin-datepicker.

bordeux avatar bordeux commented on August 14, 2024

4.1.1 (tablet, prestigo) and 4.4.4 (sgs III with cyanogenmod ) -> i updated to new version and now i cant edit time/date with keyboard.
here is my plugin def in config.xml
<gap:plugin name="com.plugin.datepicker" version="0.3.2" />

and here is video with my problem.
https://www.youtube.com/watch?v=9OUS_E7py3A

Before 20 may, everythink works fine.

from cordova-plugin-datepicker.

inazar avatar inazar commented on August 14, 2024

The problem is that plugin success callback is called on each keyboard press - multiple times. Result which is sent is '' - empty string which is converted by js to invalid date. Cordova on it's turn accepts the first callback and returns invalid date to the app.

After the js callback is called on first keyboard press (with invalid date) it is removed by cordova plugin package. So when you press 'Done' the correct date/time is collected and sent to the app BUT js callback is already removed and result is lost!!!

I've checked this with time picker, similar should happen with date picker.

Please, add the check in onTimeSet/onDateSet methods to check if the year/monthOfYear/dayOfMonth/hourOfDay/minute vars contain valid values before sending the success callback.

I'm using 4.4.3, mobile

from cordova-plugin-datepicker.

OleksandrMuzyka avatar OleksandrMuzyka commented on August 14, 2024

Please accept pull request with fix for this bug

from cordova-plugin-datepicker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.