Giter Site home page Giter Site logo

Comments (4)

aFarkas avatar aFarkas commented on June 3, 2024

This is great. Honestly, I'm not a big fan of doing everything private and then adding something as a public API. If you add more and more to public, you can also considering using prototype = jScrollObject/API and only marking things that shouldn't be used with an underscorce.
Using prototype instead of a big closure, should also consume less memory.

from jscrollpane.

vitch avatar vitch commented on June 3, 2024

I do prefer to have a public API defined as separate from the private methods. If only because I've seen the damage that users of the plugin can manage to do just using public methods! I think that a well designed and thought out API makes learning a lot easier and it seems like 90% of users of jScrollPane aren't very familiar with javascript. So the clearer and easier the better... But there are definitely methods I have missed from the API that I should have added...

from jscrollpane.

vitch avatar vitch commented on June 3, 2024

Also need to add getPercentageScrolledX, getPercentageScrolledY, setPercentageScrolledX and setPercentageScrolledY...

from jscrollpane.

vitch avatar vitch commented on June 3, 2024

Fixed in bb20907, daf30ce, 5d02222 and 0aa8e69

from jscrollpane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.