Dependencies are not inlined when using ssr.noExternal with globs

[brandonroberts]

Dependencies are not inlined when using ssr.noExternal with globs

[hi-ogawa]

Indeed, glob doesn't seem to be supported for server.deps.inline.

Vite uses createFilter utility https://github.com/vitejs/vite/blob/ec16a5efc04d8ab50301d184c20e7bd0c8d8f6a2/packages/vite/src/node/ssr/ssrExternal.ts#L38-L41 to support glob, but Vitest (vite-node) has a different logic to match patterns

vitest/packages/vite-node/src/externalize.ts

Lines 157 to 162 in f969fb0

	for (const ex of patterns) {
	if (typeof ex === 'string') {
	if (moduleDirectories.some(dir => id.includes(join(dir, ex)))) {
	return true
	}
	}

I created a repro with simpler dependencies https://github.com/hi-ogawa/reproductions/tree/main/vitest-5911-deps-inline-glob

[brandonroberts]

Thanks @hi-ogawa. I can work on a PR to support this behavior if that's whats recommended

[sheremet-va]

vite-node processes ssr.noExternal on resolved file paths, Vite processes it on bare imports, so we cannot apply the same filter.

[brandonroberts]

vite-node processes ssr.noExternal on resolved file paths, Vite processes it on bare imports, so we cannot apply the same filter.

Ok. What would be the recommended approach with globs?

[sheremet-va]

Ok. What would be the recommended approach with globs?

If I knew what to do with this, we would've already implemented it 😞

I don't know how to solve these, they were always resolved differently in Vite and Vitest. Vite can also resolve monorepo packages while Vitest expects that the package is in moduleDirectories and the name and the folder are the same.

If it's fine to keep this difference, we can just apply the glob with the same rule - svelte/* will be equal to node_modules/svelte/.+

[brandonroberts]

Thanks @sheremet-va. I think it's fine to keep this difference, and note that globs are not expected to be inlined also