Giter Site home page Giter Site logo

Comments (5)

vkalinichev avatar vkalinichev commented on May 25, 2024

Yes, I had planned to do it right this way

from postcss-rtl.

vkalinichev avatar vkalinichev commented on May 25, 2024

Fixed in 0.3.0: implemented separation for keyframes with -rtl and -rtl postfixes.

from postcss-rtl.

orouz avatar orouz commented on May 25, 2024

hey, thanks for the quick update!

i ran into a new issue after upgrading that seems related, downgrading fixed it.
i'm using react-toolbox and my build fails to compile 2 .scss files with keyframes in them. #1 #2

this is the error:

Module build failed: TypeError: Cannot read property 'replace' of undefined

the stack trace goes through 2 files besides the scss. the first is node_modules/postcss-advanced-variables/index.js and the second is node_modules/postcss/lib/lazy-result.js

and my webpack config looks like this:

       {
         test: /\.(css|scss)$/,
         loaders: ['style', 'css?modules&importLoaders=1&localIdentName=[path]___[name]__[local]___[hash:base64:5]',  'postcss', 'sass']
        },

not sure if i'm doing something wrong or that there is indeed an issue. could you clarify?

from postcss-rtl.

vkalinichev avatar vkalinichev commented on May 25, 2024

I cannot reproduce your errors: react-toolbox with your webpack.config works fine to me: both checkbox and progress-bar animations are works.

Anyway, I fully refactor @keyframes processing part in v0.3.1, if you get any errors, please create new issue.

Thanks.

from postcss-rtl.

orouz avatar orouz commented on May 25, 2024

the issue is sorted now. thank you for your work! greatly appreciated!

from postcss-rtl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.