Windows Support not working

[vkarpov15]

Windows Support not working

[vkarpov15]

Merged @chaiwa-berian 's PR and released 0.3.2 👍

[chaiwa-berian]

@StephaneMartignier I am experiencing the exact same error. It worked the first time I used it, about a week ago, but it has been failing the whole of this week. Uninstalled and re-installed it several times to no luck!

[chaiwa-berian]

@StephaneMartignier After carefully looking at the code, I noticed that the code on line number 66 of the index.js could potentially be the cause of the error. Here is the reason:

If you run run-rs -v 4.0.2 --shell without specifying the value for --dbpath, the code will return ./data as the dbPath to be used on line number 69 and line number 80!

This will fail on windows because dbPath will always be ./data whenever the --dbpath option is not passed, and so the code on lines 69 and 80 will always resolve to the path below which is not a correct syntax for a windows path that md command expects:
md .\./data !

To resolve this potential bug for windows users, the code on line 66 can be refactored to something like below:

let dbPath;
if(typeof commander.dbpath === 'string'){
   dbPath = `${commander.dbpath}` ;
}
else {
   dbPath = isWin ? 'data' : './data';
}

Note: I have not tested this code but I believe it should be able to fix the issue! Let me know what you think about this! :)

[chaiwa-berian]

I have submitted a pull request for this issue. See Pull request #14

[StephaneMartignier]

I also think that your pr will solve the issue.

Also, in the documentation for the --dbpath option it's written "dbPath" in the example command. It's should be "dbpath"