1.8.0+ Breaks at least one Ensure Overload

[vkhorikov]

1.8.0+ Breaks at least one Ensure Overload

[solvingj]

Similar issue with Result.Map and Result.OnSuccess overloads. Rolling back to 1.7.1 fixes. Also adding this overload locally fixes Map, the OnSuccess equivalent probably fixes it as well:

        public static async Task<Result<K>> Map<T, K>(this Result<T> result, Func<T, Task<K>> func, bool continueOnCapturedContext = false)
        {
            if (result.IsFailure)
                return Result.Fail<K>(result.Error);

            K value = await func(result.Value).ConfigureAwait(continueOnCapturedContext);

            return Result.Ok(value);
        }

Again, I'm confused because i re-forked and found the overloads exist in the source code on the master branch. They just won't resolve from my project on 1.8.1. Any ideas?

[vkhorikov]

@solvingj Could you post the full source code? I'll try to figure out what's wrong

[solvingj]

Sorry, refactored out many commits ago :(

I will try to create a reproduction later tonight .

[solvingj]

I'm not sure if it helps , but here is the code...

Note that AuthenticationContext comes from Microsoft.IdentityModel.Clients.ActiveDirectory

using Microsoft.IdentityModel.Clients.ActiveDirectory;

....

        public async Task<Result<AuthenticationResult>> AcquireTokenAsync(
            AuthenticationContext context, string resource)
        {
            if (await GetAuthTypeAsync() == AuthenticationType.CERTIFICATE.ToString())
            {
                return await GetClientAssertionCertificate()
                    .OnSuccess(certificate => AcquireTokenAsync(context, resource, certificate));
            }
            else
            {
                return await GetClientCredential()
                    .OnSuccess(credential => AcquireTokenAsync(context, resource, credential));
            }
        }
        public async Task<Result<ClientCredential>> GetClientCredential()
        {
            Result<string> clientId = await GetClientIdAsync();
            Result<string> clientSecret = await GetClientSecretAsync();
            return Result.Combine(clientId, clientSecret)
                    .OnSuccess(() => new ClientCredential(clientId.Value, clientSecret.Value));
        }

        public async Task<AuthenticationResult> AcquireTokenAsync(
            AuthenticationContext context, string resource, IClientAssertionCertificate certificate)
        {

            return await context.AcquireTokenAsync(resource, certificate);
        }

        public async Task<AuthenticationResult> AcquireTokenAsync(
            AuthenticationContext context, string resource, ClientCredential credential)
        {
            return await context.AcquireTokenAsync(resource, credential);
        }