Giter Site home page Giter Site logo

Comments (4)

WoosukKwon avatar WoosukKwon commented on May 18, 2024 3

Without the fix, cacheflow can suddenly hang without any notice. Let's fix this.

from vllm.

zhuohan123 avatar zhuohan123 commented on May 18, 2024 2

There are two limits for the sequence length, and we should take whichever is smaller:

  1. Model limits: For example, for OPT-13B, the learned position embedding can support only config.max_position_embeddings positions.
  2. vLLM limit: Specifically, an input cannot be longer than max_num_batched_tokens.

The real limit should be limit = min(model limit, vllm limit).

Also, for a request:

  1. If len(prompt) > limit, we should directly reject the request or return nothing.
  2. If len(prompt) + len(generated) > limit, we should stop the generation and return the partial results with the finish reason to be SequenceStatus.FINISHED_LENGTH_CAPPED.

In addition, we should not directly let the server fail when there is one request that is too long. We should return a proper error message or partial result.

from vllm.

zhuohan123 avatar zhuohan123 commented on May 18, 2024

@LiuXiaoxuanPKU

from vllm.

hmellor avatar hmellor commented on May 18, 2024

Closing as this should now be fixed.

from vllm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.