Comments (9)
Thanks for the quick response!
I tried to dig into it, but I have to admit I didn't understand yet how all the pieces fit together and won't have the time in the near future to continue working on it.
from vlsi-release-plugins.
Hi,
I think it makes sense. Historically, the only license classification I saw was https://www.apache.org/legal/resolved.html (which was basically the only motivation for the plugin itself).
So I have
Splitting "verify license" from Apache2LicenseRenderer
into a separate task sounds like the right thing to do.
from vlsi-release-plugins.
Do you think you could prepare a PR for a "check license compatibility" or "verify license compatibility" (I'm not sure regarding the naming) task in license-gather-plugin?
from vlsi-release-plugins.
By the way, do you have a use-case (a github project?) for this "license check"?
from vlsi-release-plugins.
I have a use-case, but the project I'm working on is not open source unfortunately.
from vlsi-release-plugins.
I see. Do you have a reference for the known compatible licenses? Are you going to add "allowed" licenses one by one?
For instance, the ASF has three license categories: A (allowed in source form), B (allowed only in binary artifacts), and X (forbidden everywhere).
So one of the configurations could be:
val gatherLicenes by tasks.registering(GatherLicenseTask::class) {
configuration(configurations.runtimeClasspath)
// configure license overrides, etc
}
val verifyLicenseCompatibility by tasks.register(VerifyLicenseCompatibilityTask::class) {
metadata.set(gatherLicenes) // <-- "metadata" could probably have a better naming
allow(AsfLicenseCategory.A)
}
from vlsi-release-plugins.
Allowing whole categories would be a nice usability helper, but in the general case I think we would also need the ability to allow licenses one by one as well as custom named licenses (e.g. jgit which is detected as Eclipse Distribution License (New BSD License)
)
from vlsi-release-plugins.
I think behind the lines of VerifyLicenseCompatibilityTask
below, so adding "non-standard" would be like
allow(
SimpleLicense(
"Java HTML Tidy License",
uri("http://jtidy.svn.sourceforge.net/viewvc/jtidy/trunk/jtidy/LICENSE.txt?revision=95")
)
)
class VerifyLicenseCompatibilityTask : DefaultTask() {
/**
* This is a file collected by [GatherLicenseTask].
*/
@InputFiles
val metadata = objectFactory.fileCollection()
@Input
val acceptableLicenses = objectFactory.setProperty<LicenseExpression>()
/**
* Outputs `OK` when verification is successful.
*/
@OutputFile
val resultFile = objectFactory.fileProperty()
fun allow(license: License) {
acceptableLicenses.add(license.asExpression())
}
fun allow(license: Set<License>) { // or vararg?
acceptableLicenses.add(license.asExpression())
}
fun allow(licenseExpression: LicenseExpression) {
acceptableLicenses.add(licenseExpression)
}
fun allow(licenseExpression: Set<LicenseExpression>) { // or vararg?
acceptableLicenses.add(licenseExpression)
}
...
from vlsi-release-plugins.
Sounds good 🙂
Thank you very much for pushing that idea forward!
from vlsi-release-plugins.
Related Issues (20)
- Add quotes for javap command in jandex plugin
- UnknownTaskException: Task with name 'check' not found HOT 1
- checksum-dependency-plugin cannot download pgp keys HOT 4
- XmlSlurper is too strict when reading POM files for license report HOT 1
- Problems when publishing calcite to the private maven nexus repo HOT 5
- license-gather: Handling of multi-license dependencies HOT 2
- Sigstore: signing and verification
- [Discussion] Advice for using the license gather plugin in a multi-module project. HOT 3
- [license-gather-plugin] Ability to handle multiple licensed artefacts HOT 1
- [licence-gather-plugin] Upon failure to find license, indicate the dependency HOT 5
- Upgrade grgit HOT 2
- [Jandex plugin] processJandexIndex delete resources from build dir HOT 9
- [stage-vote-release-plugin] Execution failed for task ':releaseRepository' due to missing nexus.txt file HOT 5
- [Gradle Extensions Plugin] Typed property delegates for required properties HOT 2
- After upgrade to gradle 8.x com.github.vlsi.jandex.JandexWork fails with CIRCULAR REFERENCE ArrayIndexOutOfBoundsException HOT 1
- [stage-vote-release-plugin] signingKey instead of secretKeyRingFile HOT 5
- Gradle 8.1.1: Querying the mapped value of flatmap(provider(task 'distTar', class org.gradle.api.tasks.bundling.Tar)) before task ':release:distTar' has completed is not supported HOT 1
- Dependency Dashboard
- Jandax fail when using java modularity (JPMS) HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vlsi-release-plugins.