Instance methods?

[vlucas]

Instance methods?

[vlucas]

That is understandable, and I am generally opposed to static methods myself, but in this case I thought an instance might be overkill. The class started with a single method - to load the file, and now has only two methods and will be at most 2 lines of code. Additionally, environment variables are global state, so in this case a class instance didn't really serve any real purpose.

[stanlemon]

The instance methods could be wrapped by the static methods, thus maintaining the api but also allowing for decent mocking in a project without having to resort to an alias mock. I think that's probably the most compelling reason to reconsider the statics.

is this fixed sufficiently in phpdotenv 2.x ?

[vlucas]

Yes, this is in v2.x and working well. Currently pending full release very soon.

[vlucas]

This is now in v2.0.0: https://github.com/vlucas/phpdotenv/releases/tag/v2.0.0