phpdotenv v2

[vlucas]

phpdotenv v2

[vlucas]

That would be fantastic if you have time now. I won't have time for about another week or so myself.

I was thinking about putting everything under the Dotenv namespace, and the primary class might be named something like Dotenv\Loader.

Code use would be something like:

$dotenv = new Dotenv\Loader();
$dotenv->load();
$dotenv->required(['DATABASE_URL', 'APP_ENV']);

[kelvinj]

I can take a look.

Thoughts on:

1. A fluid interface
2. Mutable by default *
3. Single file or break out into small components

* I've always found the default mutability odd, but I know the ruby library does it. I'd argue that it's better to know that you .env variables are loaded as expected giving you an environment in a known state.

[kelvinj]

Re: no.2 - ruby dotenv make use of a load method, which is immutable, and an overload method, which is mutable.

Re: the name – if you name it Dotenv\Loader and then you use Dotenv, your code will then look like new Loader() which is a bit funky. I'd prefer Dotenv\Dotenv, but it's your call.

Another thing, considering the weird apache bug highlighted in #39 when using getenv() it might be an idea to encourage usage of $_ENV instead… what do you think?

[vlucas]

Using Dotenv\Dotenv is fine. Also, this project was originally inspired by the Ruby version, but I don't want to be obsessed with matching it 1:1 in all respects.

[kelvinj]

@vlucas ok. What are your thoughts on immutability?

[bcremer]

I would like to keep a static factory method so I am not forced to use a instance variable:

\Dotenv\Dotenv::create()->load();

Or to mimic the v1. api:

\Dotenv\Dotenv::load(); // loads .env and returns instance

As of PHP 5.4 the following is also possible:

(new \Dotenv\Dotenv)->load();

[kelvinj]

I'm almost done with an initial effort, which is more to do with testing the waters on some stuff than a proposed final solution, just to see what feels right, what feels wrong …etc.