Sudden breaking change between 1.0.8 and 1.0.9 with the {$FOO} syntax for nested variables

[vlucas]

Sudden breaking change between 1.0.8 and 1.0.9 with the {$FOO} syntax for nested variables

[motin]

Aha, I see the discussion and vote-procedure in pr #37 @kelvinj)

[kelvinj]

@motin are you able to provide a PR? Dotenv v1 should probably now support both variants for BC.

Having 2 ways of doing it is confusing in itself though, and as @vlucas prefers the PHP style I think the upcoming v2 will probably stick with the PHP style.

FWIW v2 also allows multiple loaders, so it will accept a .env.php loader to load variables from a PHP file that returns an array. Therefore, the argument to follow bash-style variable interpolation diminishes somewhat.

[vlucas]

After thinking about it, I think we should stick with bash-style variable interpolation. This is consistent with defining environment variables everywhere else, and still allows the environment variables to work properly when exported or sourced directly in a bash session.

[motin]

Dotenv v1 should probably now support both variants for BC.

It didn't when I tried. With $FOO set to the string "boo", I ended up with variables like baz_{$FOO}_zoo becoming baz_{boo_zoo.

@motin are you able to provide a PR?

Would it be enough to revert the change in v1.0.8...v1.0.9#diff-9fc34dc20f14743cc88df0c70b48555cL187 or was there other bugs with the previous implementation?

FWIW v2 also allows multiple loaders, so it will accept a .env.php loader to load variables from a PHP file that returns an array. Therefore, the argument to follow bash-style variable interpolation diminishes somewhat.

Sounds good, but I'd suggest that only the php-loader should allow PHP-style variables (and most likely the implementation will not at all be dependent on regex), while remaining bash-style variable interpolation in .env (or .env.sh).

After thinking about it, I think we should stick with bash-style variable interpolation. This is consistent with defining environment variables everywhere else, and still allows the environment variables to work properly when exported or sourced directly in a bash session.

Great to hear! I'll wait with upgrading until 1.2.0 comes out then (please don't add a new breaking change as minor version 1.1.1 :))

[kelvinj]

It didn't when I tried.

Sorry, I wasn't clear. The bash style was removed and I was saying it should be corrected.

Would it be enough to revert the change in v1.0.8...v1.0.9#diff-9fc34dc20f14743cc88df0c70b48555cL187 …

I think the implementation changed. It should be enough to update the tests & fix the regex.

[vlucas]

In v2.0.0 (tagged just now), it's all bash-style syntax.